Enhance Delete Modal and error display#3337
Merged
Merged
Conversation
Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3337 +/- ##
==========================================
- Coverage 54.01% 54.00% -0.02%
==========================================
Files 2402 2403 +1
Lines 87402 87609 +207
Branches 24207 24294 +87
==========================================
+ Hits 47212 47310 +98
- Misses 38694 38789 +95
- Partials 1496 1510 +14
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
asmasarw
force-pushed
the
fix/delete-dialog
branch
from
fa38a0f to
ef0adca
Compare
mareklibra
requested changes
Jun 9, 2026
| // ── Delete dialog ──────────────────────────────────────────────────────── | ||
| const [deleteOpen, setDeleteOpen] = useState(false); | ||
| const [deletingItem, setDeletingItem] = useState<T | null>(null); | ||
| const [deleteSubmitting, setDeleteSubmitting] = useState(false); |
Member
There was a problem hiding this comment.
when deleteSubmitting is true, the handleCloseDelete shuld be blocked till the request is done.
|
mareklibra
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets
Changes
Enhance the Delete Dialog UX: keep the dialog open on API errors and display them inline, disable the Delete button and show a loading spinner during submission to prevent double-clicks, use an error-red background for the Delete button, and suppress the external action alert for delete errors in favour of the in-dialog error banner.