fix(lightspeed): delete-button-bg-color#3324
Closed
rohitratannagar wants to merge 1 commit into
Closed
Conversation
Signed-off-by: rohitratannagar <rohitratannagar2003@gmail.com>
rohitratannagar
requested review from
a team,
karthikjeeyar,
rohitkrai03 and
yangcao77
as code owners
Changed Packages
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3324 +/- ##
==========================================
- Coverage 53.92% 53.91% -0.01%
==========================================
Files 2379 2379
Lines 86125 86132 +7
Branches 23913 23922 +9
==========================================
- Hits 46441 46440 -1
- Misses 39383 39391 +8
Partials 301 301
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
its-mitesh-kumar
requested changes
Jun 9, 2026
| color: theme.palette.error?.contrastText || '#fff', | ||
| '&:hover': { | ||
| backgroundColor: theme.palette.error?.dark || '#731f00', | ||
| }, |
Member
There was a problem hiding this comment.
I think we should not use this hardcoded color #b1380b . We should use theme specific color.
| color: theme.palette.error?.contrastText || '#fff', | ||
| '&:hover': { | ||
| backgroundColor: theme.palette.error?.dark || '#731f00', | ||
| }, |
Member
There was a problem hiding this comment.
We should not use this hardcoded color #b1380b . We should use theme specific color.
Contributor
Author
|
closing this in favour of: #3346 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
theme-aware error colors instead of relying on MUI's color="error" prop
so color="error" falls back to MUI's default (#d32f2f) which differs from the expected RHDH
error color (#b1380b)
correct appearance in both RHDH and the dev workspace
Why
The RHDH theme currently does not define the following error palette colors:
These need to be defined in the RHDH theme (@red-hat-developer-hub/backstage-plugin-theme) so
that any component using color="error" or theme.palette.error gets the correct RHDH-branded
colors instead of MUI defaults. The expected values are:
Once the RHDH theme defines these, the hardcoded fallbacks in this PR become redundant safety
nets.