Skip to content

feat(redis): Inject creds via volume#1112

Open
olivergondza wants to merge 5 commits intoredhat-developer:masterfrom
olivergondza:redis-creds-via-volume
Open

feat(redis): Inject creds via volume#1112
olivergondza wants to merge 5 commits intoredhat-developer:masterfrom
olivergondza:redis-creds-via-volume

Conversation

@olivergondza
Copy link
Copy Markdown
Collaborator

@olivergondza olivergondza commented Mar 31, 2026

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Avoid passing the password over environment variables and command line arguments. Downstream of:

Have you updated the necessary documentation?

  • [no] Documentation update is required by this PR.
  • [no] Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Blocked until the upstream PRs are merged.

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Mar 31, 2026
@openshift-ci openshift-ci bot requested a review from jannfis March 31, 2026 11:04
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adamsaleh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from trdoyle81 March 31, 2026 11:04
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@olivergondza olivergondza changed the title feat(redis): Inject creds via volume (WIP) feat(redis): Inject creds via volume Apr 14, 2026
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@olivergondza olivergondza force-pushed the redis-creds-via-volume branch from 91ed74d to 57ed555 Compare April 14, 2026 12:56
@olivergondza
Copy link
Copy Markdown
Collaborator Author

Test failures are relevant...

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@olivergondza
Copy link
Copy Markdown
Collaborator Author

/test v4.14-kuttl-sequential

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 16, 2026

@olivergondza: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-sequential 297d066 link false /test v4.14-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant