[TypeDeclaration] Skip constructor-assigned property in PropertyTypeFromStrictSetterGetterRector

[TomasVotruba]

Problem

PropertyTypeFromStrictSetterGetterRector inferred a wrong property type when a constructor assigns the property.

Given:

class MaxMindDoNotSellList
{
    private $listPath;

    public function __construct(CoreParametersHelper $coreParametersHelper)
    {
        $this->listPath = $coreParametersHelper->get('maxmind_do_not_sell_list_path', '');
    }

    public function getListPath(): string
    {
        return $this->listPath;
    }

    public function setListPath(string $path): void
    {
        $this->listPath = $path;
    }
}

it produced:

-    private $listPath;
+    private \Mautic\CoreBundle\Helper\CoreParametersHelper|string $listPath;

Cause

SetterTypeDeclarationPropertyTypeInferer used hasOnlyPropertyAssign(), which matches any single-statement $this->prop = <expr> method — including the constructor. The constructor got treated as a setter, so its first param type (CoreParametersHelper) leaked into the inference, unioning with the getter's string.

Fix

Add ClassMethodAndPropertyAnalyzer::hasOnlyFirstParamPropertyAssign(), which additionally requires the assigned value to be exactly the method's first parameter variable ($this->prop = $param), and use it in the setter inferer. The shared hasOnlyPropertyAssign() is left unchanged (still used by Php84\SetterAndGetterFinder).

Now the property is correctly typed private string $listPath;.

Tests

• constructor_assigned_no_default.php.inc — direct constructor param assign
• constructor_non_param_assign.php.inc (+ Source/SomeConfigHelper.php) — constructor assigns a method-call result; constructor is ignored, setter provides string