Add test fixture for demonstrating behavior changing parentheses remo…#8121
Closed
j-dobr wants to merge 1 commit into
Closed
Add test fixture for demonstrating behavior changing parentheses remo…#8121j-dobr wants to merge 1 commit into
j-dobr wants to merge 1 commit into
Conversation
…val in SimplifyConditionsRector
simonschaufi
pushed a commit
to simonschaufi/rector-src
that referenced
this pull request
Jul 2, 2026
…itionsRector (rectorphp#8122) Fixes rectorphp#8121 - inverting a binary op whose operand is a ternary dropped the parentheses, changing evaluation due to lower ternary precedence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This condition evaluates as false:
But it is simplified into this, which, due to removal of parentheses around inner condition, evaluates as true:
Added failing fixture (might not be minimal reproducer, but it illustrates it nicely).