[Php81] Skip ArrayToFirstClassCallableRector on serialized callable array keys and Definition::setFactory()#8117
Merged
Conversation
…rray keys and Definition::setFactory()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip
ArrayToFirstClassCallableRectorwhen the[$value, 'method']array is meant to stay an array rather than become a first class callable:'callback','factory', or'validation_groups'— likely serialized to a callable string\Symfony\Component\DependencyInjection\Definition::setFactory(), which does not accept a first class callableContext is marked during parsing via a new
AttributeKey::IS_ARRAY_AS_STRING_CALLABLEset inContextNodeVisitor, then checked in the rule.Covered by 4 new skip fixtures.