[CodingStyle] Skip private parent methods in MakeInheritedMethodVisibilitySameAsParentRector#8114
Merged
Merged
Conversation
…ilitySameAsParentRector (not inherited)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
MakeInheritedMethodVisibilitySameAsParentRectornarrows a child method's visibility to match a private parent method of the same name. But private methods are not inherited — the child method does not override them, so there is no inheritance relationship and no reason to align visibility.The rule rewrote the child to
private function run(), silently removing it from the public API even though PHP places no visibility constraint between a private parent method and a same-named child method.Fix
Skip private parent methods when aligning visibility (they are not inherited). The now-unreachable
privatebranches in the two helpers are removed.The previous
private.php.incfixture encoded the buggy narrowing as expected output; it becomes a no-change fixture (skip_private_parent_method.php.inc).Protected/public parent behavior is unchanged.