[DeadCode] Skip constant compare from vendor/ on NarrowWideUnionReturnTypeRector

[samsonasik]

When constant vendor can be different value, eg allow monolog v2 and v3:

"monolog/monolog": "^2.0 || ^3.0"

The Logger::API value are different. So this check is on purpose:

    public function createLogRecord(int $level): array|LogRecord
    {
        return Logger::API === 2
            ? ['level' => $level]
            : new LogRecord();
    }

and should be skipped.

[samsonasik]

@TomasVotruba ready 👍

[samsonasik]

@TomasVotruba ready 👍

[TomasVotruba]

What is actually wrong with the provided snippet now? What does Rector do?
Not sure if worth parsing composer.json for this condition.

[samsonasik]

The existing behaviour is change union return type:

-    public function createLogRecord(int $level): array|LogRecord
+    public function createLogRecord(int $level): array

due to Logger::API === 2 is always valid on specific installed version, but when it install another version major, it become invalid.

so if there is ternary return, and it compare constant fetch, it needs to lookup composer.json check, and verify the multiple major versions definition.

[TomasVotruba]

Looks good now, let's ship it