Skip to content

Security: Unsafe File Write with User-Controlled Path #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Security: Unsafe File Write with User-Controlled Path #1099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-docgen-cli/src/commands/parse/output/outputResult.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { writeFile } from 'fs/promises';
import { resolve } from 'path';
import type { Documentation } from 'react-docgen';

export default async function outputResult(
Expand All @@ -12,7 +13,12 @@ export default async function outputResult(
);

if (output) {
await writeFile(output, result, 'utf-8');
const resolvedOutput = resolve(output);
const cwd = resolve('.');
if (!resolvedOutput.startsWith(cwd)) {
throw new Error('Output path must be within the current working directory');
}
await writeFile(resolvedOutput, result, 'utf-8');
} else {
process.stdout.write(result + '\n');
}
Expand Down