Skip to content

RDKEMW-18233: Route console logs to sky-message.log for jsruntime#132

Merged
vjain008 merged 1 commit into
developfrom
topic/RDKEMW-18233
May 14, 2026
Merged

RDKEMW-18233: Route console logs to sky-message.log for jsruntime#132
vjain008 merged 1 commit into
developfrom
topic/RDKEMW-18233

Conversation

@gurpreet319
Copy link
Copy Markdown
Contributor

Reason for change: Added Support to route console logs to skymessage
Test Procedure: build should be successful
Risk: low
Priority: P2

Copilot AI review requested due to automatic review settings May 12, 2026 12:31
@gurpreet319 gurpreet319 requested a review from a team as a code owner May 12, 2026 12:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a JavaScriptCore (JSC) console logging bridge for jsruntime that routes console.* output through NativeJSLogger (and, when enabled, ethanlog / sky-message.log) by injecting wrapper functions into the JS global context.

Changes:

  • Added JSC C++ callbacks (consoleLogCallback, consoleWarnCallback, etc.) to convert JS arguments to strings and forward them to NativeJSLogger.
  • Injected a JS wrapper (behind USE_ETHANLOG + ETHAN_LOGGING_PIPE) that overrides console.log/warn/error/debug/info to forward logs to the injected native callbacks.
  • Exposed the new callback declarations in JavaScriptUtils.h.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
src/jsc/JavaScriptUtils.cpp Adds native JSC callback implementations for console routing to NativeJSLogger.
src/jsc/JavaScriptContext.cpp Injects native functions and a JS console wrapper when ethanlog is enabled via env.
include/jsc/JavaScriptUtils.h Declares the new console callback functions for use by the context injector.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/jsc/JavaScriptContext.cpp Outdated
Comment thread src/jsc/JavaScriptUtils.cpp Outdated
Comment thread src/jsc/JavaScriptUtils.cpp
Comment thread src/jsc/JavaScriptUtils.cpp
Comment thread src/jsc/JavaScriptContext.cpp Outdated
Comment thread src/jsc/JavaScriptUtils.cpp
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

Comment thread src/jsc/JavaScriptContext.cpp Outdated
Comment thread src/jsc/JavaScriptUtils.cpp
Comment thread src/jsc/JavaScriptUtils.cpp
Comment thread src/jsc/JavaScriptUtils.cpp
Comment thread src/jsc/JavaScriptContext.cpp
Comment thread src/jsc/JavaScriptContext.cpp
Comment thread src/jsc/JavaScriptUtils.cpp
Comment thread src/jsc/JavaScriptUtils.cpp
Reason for change: Added Support to route console logs to skymessage
Test Procedure: build should be successful
Risk: low
Priority: P2
@gurpreet319 gurpreet319 force-pushed the topic/RDKEMW-18233 branch from 68982ea to 798c70b Compare May 14, 2026 11:56
@vjain008 vjain008 merged commit f905781 into develop May 14, 2026
8 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants