RDKEMW-18233: Route console logs to sky-message.log for jsruntime#132
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a JavaScriptCore (JSC) console logging bridge for jsruntime that routes console.* output through NativeJSLogger (and, when enabled, ethanlog / sky-message.log) by injecting wrapper functions into the JS global context.
Changes:
- Added JSC C++ callbacks (
consoleLogCallback,consoleWarnCallback, etc.) to convert JS arguments to strings and forward them toNativeJSLogger. - Injected a JS wrapper (behind
USE_ETHANLOG+ETHAN_LOGGING_PIPE) that overridesconsole.log/warn/error/debug/infoto forward logs to the injected native callbacks. - Exposed the new callback declarations in
JavaScriptUtils.h.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/jsc/JavaScriptUtils.cpp |
Adds native JSC callback implementations for console routing to NativeJSLogger. |
src/jsc/JavaScriptContext.cpp |
Injects native functions and a JS console wrapper when ethanlog is enabled via env. |
include/jsc/JavaScriptUtils.h |
Declares the new console callback functions for use by the context injector. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ee60d01 to
68982ea
Compare
Reason for change: Added Support to route console logs to skymessage Test Procedure: build should be successful Risk: low Priority: P2
68982ea to
798c70b
Compare
vjain008
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added Support to route console logs to skymessage
Test Procedure: build should be successful
Risk: low
Priority: P2