update stateful_kv_size correctly in mismatch case#170
Merged
Conversation
wine99
commented
May 19, 2026
| state.set_state(new_state_tensor); | ||
| } | ||
| r_ctx->stateful_kv_size = pos_data[0] + 1; | ||
| r_ctx->stateful_kv_size = pos_data[0] + pos_shape[3]; |
Collaborator
Author
There was a problem hiding this comment.
@cavusmustafa Although pos_data[0] + 1 did not trigger any bug and the /regen command in llama-cli was working correctly because the pos_shape[3] happened to be 1, I believe the correct expression is pos_data[0] + pos_shape[3]
wine99
force-pushed
the
dev_backend_openvino
branch
from
fba54ea to
4f247b1
Compare
wine99
force-pushed
the
stateful_kv_size_mismatch
branch
from
3227cf0 to
2896802
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.