Fix ingest compatibility metadata gaps#22
Open
haasonsaas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes three ingest compatibility gaps I found while reviewing the core SDK/OpenLLMetry path:
gen_ai.prompt.N.userwhen normalizing indexedgen_ai.prompt.*messages.raindrop.replayRunId, whichparse.tsdocumented as supported but did not actually read.llm.usage.total_tokens, instead of dropping it when split input/output token counts are unavailable.I searched existing issues/PRs for
gen_ai.prompt.0.user, Cohere,replayRunId, andtotal_tokens. I did not find an existing issue/PR for these follow-ups. The only related open PR is #19, which covers the separate legacygen_ai.usage.prompt_tokens/gen_ai.usage.completion_tokensmismatch.Details
spans.total_tokensplus the generated Drizzle migration/assets.total_tokensthrough ingest, cloud/saved run mapping, API schemas, span skeletons, filtering/sorting, and run/detail displays..userprompt normalization, and total-only usage attributes.Validation
bun test tests/parse.test.tsbun test tests/bun x tsc --noEmitbun run buildbun run lint(passes with existing warnings)