Skip to content

fix(filters): fix include-dark with meta-resolved image paths #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcanouil wants to merge 1 commit into from
Closed

fix(filters): fix include-dark with meta-resolved image paths #2086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions filters/include-dark.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ local function dark_path(src)
return path[1] .. "-dark" .. path[2]
end

local function new_image(img, src, class)
local function new_image(img, src, class)
local new_classes = pandoc.List.filter(img.classes, function(c)
return c ~= "include-dark"
end)
Expand All @@ -15,10 +15,14 @@ end

function Image(img)
if img.classes:includes("include-dark") then
local dark_img = new_image(img, dark_path(img.src), "dark-content")
local light_img = new_image(img, img.src, "light-content")
local stem, ext = pandoc.path.split_extension(img.src)
local _, inner_ext = pandoc.path.split_extension(stem)
-- Quarto adds a spurious extension when src is resolved via {{< meta >}};
-- strip it when the same extension appears twice (e.g. foo.png.png).
local src = (inner_ext == ext) and stem or img.src
local dark_img = new_image(img, dark_path(src), "dark-content")
local light_img = new_image(img, src, "light-content")
return {dark_img, light_img}
end
return img
end

Loading