Gate native-pampa round-trip tests behind opt-in env var (bd-d8nol0xn)#347
Merged
Merged
Conversation
…opt-in env var (bd-d8nol0xn) The two bd-sjb4pzx8 round-trip tests shell out to the native `pampa` binary (build + per-fixture subprocess over temp files): the throwaway tiptap-roundtrip-spike, and the production fidelity guard richtext/roundtrip (via test-utils/pampaOracle). They are slow and intermittently flaky under the parallel load of a full `vitest run` / `cargo xtask verify` — a transient process/IO race around concurrent `cargo build --bin pampa` + temp dirs — while passing in isolation and on re-run. They are measurement / fidelity oracles, not routine gates. Gate both with `describe.skipIf(!process.env.QUARTO_RUN_PAMPA_ROUNDTRIP)` so they are skipped in routine runs and runnable on demand: QUARTO_RUN_PAMPA_ROUNDTRIP=1 npx vitest run src/q2-preview/richtext/roundtrip.test.ts Default preview-renderer unit run is now 468 passed | 32 skipped (was 500 with the oracle running), ~0.7s, with no pampa subprocesses — so it can no longer flake. The fast jsdom rich-text unit tests (caretFromClick, RichTextEditor.caret) are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
I don't believe the bot very much here, but these are not especially important tests (famous last words..) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The two bd-sjb4pzx8 round-trip tests shell out to the native
pampabinary (build + per-fixture subprocess over temp files) and are slow + intermittently flaky under the parallel load of a fullvitest run/cargo xtask verify— a transient process/IO race around concurrentcargo build --bin pampaand temp dirs — while passing in isolation and on re-run. They are measurement/fidelity oracles, not routine gates:tiptap-roundtrip-spike/roundtrip.test.ts— the throwaway feasibility spike.richtext/roundtrip.test.ts— the production round-trip fidelity guard (viatest-utils/pampaOracle).Change
Gate both with
describe.skipIf(!process.env.QUARTO_RUN_PAMPA_ROUNDTRIP)so they're skipped in routine runs and runnable on demand:(The richtext guard keeps its existing
pampaAvailable()skip too.) Each file's header documents the opt-in.Scope / what's kept
Only the two native-pampa oracle tests are gated. The fast jsdom rich-text unit tests of shipping behavior —
caretFromClick.test.ts,RichTextEditor.caret.integration.test.tsx— are untouched and still run every time.Verification
vitest run(preview-renderer): 468 passed | 32 skipped, ~0.7s, no pampa subprocesses → can no longer flake (was 500 with the oracle running, ~6–23s + noisy oracle output).QUARTO_RUN_PAMPA_ROUNDTRIP=1 … richtext/roundtrip.test.ts→ 15 passed (shells out to pampa as before).cargo xtask verify --skip-hub-buildgreen.Strand: bd-d8nol0xn (discovered via the flake hit in bd-pvcnea83 / PR #346).
🤖 Generated with Claude Code