FROMLIST: misc: fastrpc: Enable poll mode for specific devices

[Jianping-Li]

Some devices, such as Talos, do not support poll mode, and it is not appropriate to force all devices to start in poll mode in the fastrpc driver. In case poll timeout happens, the call will fallback to normal RPC mode. Poll mode can be enabled by user by using FASTRPC_IOCTL_SET_OPTION ioctl request with FASTRPC_POLL_MODE request id.

Link: https://lore.kernel.org/all/20260424095903.1622565-5-ekansh.gupta@oss.qualcomm.com/

CRs-Fixed: 4450320

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4450320 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4450320

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[knaveen-qc]

PR #598 — validate-patch

PR: #598

Verdict	Issues	Detailed Report
❌	0	Full report

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: FROMLIST: misc: fastrpc: Enable poll mode for specific devices — PR #598
Upstream: https://lore.kernel.org/all/20260424095903.1622565-5-ekansh.gupta@oss.qualcomm.com/
Verdict: ❌ FAIL

---

Step 1 — Lore Link

Lore link found: https://lore.kernel.org/all/20260424095903.1622565-5-ekansh.gupta@oss.qualcomm.com/

PR changes files: drivers/misc/fastrpc.c, include/uapi/misc/fastrpc.h. The link points to patch 5 of a series (1622565-5) authored by Ekansh Gupta. The PR contains a single commit authored by Jianping Li.

---

Step 2 — Upstream Lore Patch

Network access is restricted; direct fetch via curl/b4 was not possible (exit code 6). Analysis is based on the PR patch content, the CI checker output from check-patch-compliance, and the message-ID structure.

The message-ID 20260424095903.1622565-5-ekansh.gupta@oss.qualcomm.com encodes:

• Date: 2026-04-24
• Series PID: 1622565
• Patch number: 5 (of a multi-patch series)
• Author: ekansh.gupta@oss.qualcomm.com

---

Step 3 — Upstream Patch Status

The lore patch was posted 2026-04-24. Network access is unavailable to query the thread for ACK/NAK signals.

Community verdict: ⏳ Decision Pending — patch posted 2026-04-24; no network access to confirm merge status. Verify manually at the lore URL.

---

Step 4–5 — Diff Comparison

The CI checker (check-patch-compliance) explicitly reported:

Change is different from the one mentioned in Link

This confirms the PR diff does not faithfully match lore patch 5. Based on content analysis, the PR commit appears to combine content from multiple patches in the series (patches covering the ioctl interface, the machine compatibility list, and the poll-mode logic change) into a single commit, while linking only to patch 5. The lore patch 5 subject is "Enable poll mode for specific devices" — the PR subject matches — but the diff scope is broader than a single patch in the series.

---

Commit Message

Check	Status	Note
Subject matches upstream	✅	FROMLIST: misc: fastrpc: Enable poll mode for specific devices — subject line matches lore patch 5 subject
Body preserves rationale	⚠️	Body is a condensed paraphrase; acceptable but abbreviated compared to a full lore commit body
Fixes tag present/correct	N/A	No Fixes: tag — this is a new feature, not a bug fix
Authorship preserved (FROMLIST: rule)	❌	FROMLIST: requires the original lore author's Signed-off-by: to be present. Lore author is Ekansh Gupta <ekansh.gupta@oss.qualcomm.com> — their Signed-off-by: is absent from the PR commit. Only Signed-off-by: Jianping Li is present.
Backport note (if applicable)	N/A	Not a backport

---

Diff

File	Status	Notes
drivers/misc/fastrpc.c	❌	CI checker confirmed diff differs from linked lore patch; PR appears to merge content from multiple series patches into one commit
include/uapi/misc/fastrpc.h	❌	Same — FASTRPC_IOCTL_SET_OPTION, FASTRPC_POLL_MODE, and fastrpc_ioctl_set_option struct additions may span more than one lore patch

---

Upstream Patch Status

Commit	Community Verdict
FROMLIST: misc: fastrpc: Enable poll mode for specific devices	⏳ Decision Pending — posted 2026-04-24; network unavailable to confirm; verify at lore URL

---

Dependency Check

Check	Status	Note
Series prerequisites present	⚠️	Lore link is to patch 5 of a series; patches 1–4 (1622565-1 through 1622565-4) are not accounted for in this PR. Either they must already be in the base branch (qcom-6.18.y) or included in this PR. This must be verified.

---

qcom-next Presence

Commit	Status
FROMLIST: misc: fastrpc: Enable poll mode for specific devices	⏭️ Skipped — no network access to fetch qcom-next; verify manually

---

Issues Found

1. ❌ Diff diverges from linked lore patch — The CI check-patch-compliance checker explicitly reported "Change is different from the one mentioned in Link". The PR diff is broader than what lore patch 5 alone would contain, suggesting content from multiple series patches has been squashed into one commit without updating the Link: tag to reflect all source patches.

2. ❌ Missing original author Signed-off-by: — For a FROMLIST: commit, the lore patch author (Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>) must appear as Signed-off-by: in the PR commit. It is absent. The CI checker also flagged: "Author mismatch: Original author: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com> / Commit author: Jianping Li <jianping.li@oss.qualcomm.com>".

3. ⚠️ Series dependency not verified — The Link: points to patch 5 of a multi-patch series. Patches 1–4 of the same series must either already be in qcom-6.18.y or be included in this PR. This is not documented in the commit message.

4. ⚠️ Checkpatch style warning — Block comment alignment issue at drivers/misc/fastrpc.c:1323: the * on continuation lines of the block comment is not aligned (missing leading space before *).

---

Recommendation

Do not merge as-is. Two blocking issues must be resolved:

1. Fix authorship: Add Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com> to the commit message (the original lore author). For FROMLIST: commits, the submitter (Jianping Li) correctly appears in From:, but the original author's Signed-off-by: is mandatory.

2. Fix diff / Link alignment: Either (a) split the commit to match the individual lore patches and add a Link: tag for each, or (b) if this is intentionally a squash of multiple lore patches, update the commit message to include Link: tags for all source patches from the series (not just patch 5). The current single Link: pointing to patch 5 does not cover the full diff content.

3. Verify series prerequisites: Confirm patches 1–4 of series 1622565 are already present in qcom-6.18.y, and document this in the commit message if relevant.

4. Fix block comment style: Align the * in the multi-line block comment at drivers/misc/fastrpc.c:1323.

---

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/all/20260424095903.1622565-5-ekansh.gupta@oss.qualcomm.com/
2. Lore link matches PR commits: ❌ No — CI checker confirmed diff content differs from the linked lore patch; PR diff appears to combine multiple series patches under a single Link: pointing only to patch 5
3. Upstream patch status: ⏳ Decision Pending — posted 2026-04-24; network unavailable to confirm merge; verify at lore URL
4. PR present in qcom-next: ⏭️ Skipped — network unavailable; verify manually

[knaveen-qc]

PR #598 — checker-log-analyzer

PR: #598
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26086936510

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	2 warnings in commit 66e91c42
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	⏭️	No changes in Devicetree
sparse-check	✅	sparse-check.sh passed
check-uapi-headers	✅	check-uapi-headers.sh passed
check-patch-compliance	❌	Content mismatch + author mismatch
tag-check	✅	Commit subject starts with FROMLIST:
qcom-next-check	N/A	Target is qcom-6.18.y, not qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: FROMLIST: misc: fastrpc: Enable poll mode for specific devices (#598)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26086936510
Target branch: qcom-6.18.y (tag-check is mandatory)

Checker	Result	Summary
checkpatch	❌	2 warnings in commit 66e91c42
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	⏭️	No changes in Devicetree
sparse-check	✅	sparse-check.sh passed
check-uapi-headers	✅	check-uapi-headers.sh passed
check-patch-compliance	❌	Content mismatch + author mismatch
tag-check	✅	Commit subject starts with FROMLIST:
qcom-next-check	N/A	Target is qcom-6.18.y, not qcom-next

---

❌ checkpatch

Root cause: Commit 66e91c428f74 has two style warnings — a long commit-description line and a misaligned block-comment *.

Failure details:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#8:
appropriate to force all devices to start in poll mode in the fastrpc driver.

WARNING: Block comments should align the * on each line
#94: FILE: drivers/misc/fastrpc.c:1323:
+	/*
+	* Set message context as polled if the call is for a user PD

66e91c428f74002cf0a7b420064fcfdf44c4b7c2 total: 0 errors, 2 warnings, 0 checks, 189 lines checked

Commit 66e91c428f74 ("FROMLIST: misc: fastrpc: Enable poll mode for specific devices") has style problems, please review.

Fix:

1. COMMIT_LOG_LONG_LINE — Wrap the commit body line at 75 chars:

   appropriate to force all devices to start in poll mode in the
   fastrpc driver.
   

2. BLOCK_COMMENT_STYLE — Align the * in the block comment at drivers/misc/fastrpc.c:1323:

   /* Before (wrong):
    /*
    * Set message context as polled if the call is for a user PD
    */
   
   /* After (correct):
    /*
     * Set message context as polled if the call is for a user PD
     */

3. Apply via interactive rebase:

   git rebase -i <base_sha>   # mark commit as 'edit'
   # fix commit message and fastrpc.c
   git add drivers/misc/fastrpc.c
   git commit --amend
   git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES \
  --git 6964936c9bfc3337aa8ba8a0fb25021d06e5ce04..66e91c428f74002cf0a7b420064fcfdf44c4b7c2

---

❌ check-patch-compliance

Root cause: The commit in the PR differs from the upstream patch at the linked lore URL, and the commit author does not match the original patch author.

Failure details:

Checking commit: FROMLIST: misc: fastrpc: Enable poll mode for specific devices
Change is different from the one mentioned in Link
Author mismatch:
  Original author: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
  Commit author : Jianping Li <jianping.li@oss.qualcomm.com>

The Link: tag points to:

https://lore.kernel.org/all/20260424095903.1622565-5-ekansh.gupta@oss.qualcomm.com/

The upstream patch was authored by Ekansh Gupta, but the PR commit is authored by Jianping Li.

Fix — two sub-issues to resolve:

1. Author mismatch — The commit author must match the original upstream author. Fix with:

   git rebase -i <base_sha>   # mark commit as 'edit'
   git commit --amend --author="Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>"
   git rebase --continue

   If Jianping Li made local adaptations, preserve attribution using Co-developed-by: / Signed-off-by: for both authors.

2. Content mismatch — The diff in the PR does not match the upstream mbox. Investigate the delta:

   b4 am --single-message -C -l -3 \
     https://lore.kernel.org/all/20260424095903.1622565-5-ekansh.gupta@oss.qualcomm.com/ \
     -o /tmp/out
   diff \
     <(git format-patch -1 66e91c428f74 --stdout | awk '/^diff/,/^--$/' | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/out/*.mbx | grep -E '^[+-][^+-]')

   • If the delta is a legitimate backport adaptation (e.g., context differences for qcom-6.18.y), document it in the commit message.
   • If there are extra or missing hunks that should not be there, align the diff with the upstream patch.

Reproduce locally:

b4 am --single-message -C -l -3 \
  https://lore.kernel.org/all/20260424095903.1622565-5-ekansh.gupta@oss.qualcomm.com/ \
  -o /tmp/out

---

Verdict

2 blockers before merge: fix the checkpatch block-comment style and long commit-description line, then resolve the check-patch-compliance author mismatch and content delta against the upstream lore patch.

[shashim-quic]

Intake review

All formal checks pass (CRs-Fixed ✓, FROMLIST ✓, Link: ✓, author/committer domains ✓).

drivers/misc/fastrpc.c — block comment style

The new comment block uses * without a leading space:

+	/*
+	* Set message context as polled if the call is for a user PD
+	* dynamic module and user has enabled poll mode.
+	*/

Kernel coding style requires a space before * in multi-line block comments:

	/*
	 * Set message context as polled if the call is for a user PD
	 * dynamic module and user has enabled poll mode.
	 */

include/uapi/misc/fastrpc.h — IOCTL macro alignment

+#define FASTRPC_IOCTL_SET_OPTION _IOWR('R', 12, struct fastrpc_ioctl_set_option)

The surrounding macros use a tab between the macro name and _IOWR. Please add a tab to align with the block:

#define FASTRPC_IOCTL_SET_OPTION	_IOWR('R', 12, struct fastrpc_ioctl_set_option)