FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD

[Jianping-Li]

Reserve memory region for audio PD dynamic loading and remote heap requirements. Add the required VMID list for memory ownership transfers.

Link: https://lore.kernel.org/all/20260424-talosaudio-v3-1-9e2ad5d78a2e@oss.qualcomm.com/
CRs-Fixed: 4483711

[knaveen-qc]

PR #596 — validate-patch

PR: #596

Verdict	Issues	Detailed Report
❌	0	Full report

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD (#596)
Upstream: https://lore.kernel.org/all/20260424-talosaudio-v3-1-9e2ad5d78a2e@oss.qualcomm.com/
Verdict: ❌ FAIL

---

Commit Message

Check	Status	Note
Subject matches upstream	✅	FROMLIST: prefix correctly prepended to lore subject
Body preserves rationale	✅	Commit body faithfully describes the memory reservation and VMID list purpose
Fixes tag present/correct	✅ N/A	No Fixes: tag needed — this is a feature addition, not a bug fix
Authorship preserved	✅	FROMLIST: rule: submitter is legitimately in From:; lore author Jianping Li is present in Signed-off-by:
Backport note (if applicable)	N/A	Not a backport
Co-developed-by used correctly	✅ N/A	No Co-developed-by: present

---

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/talos.dtsi	❌	DTS node adsp-rpc-remote-heap is missing a terminating semicolon — } should be };

---

Upstream Patch Status

Commit	Community Verdict
arm64: dts: qcom: talos: Add memory-region for audio PD	⏳ Decision Pending (unknown) — lore.kernel.org unreachable from this environment; message-ID 20260424-talosaudio-v3-1-9e2ad5d78a2e@oss.qualcomm.com encodes revision v3 patch 1 of a series posted 2026-04-24; no network access to verify thread status

---

Dependency Check

• ⚠️ The message-ID encodes v3-1, indicating this is patch 1 of a series. Sibling patches (e.g. patch 2+) may be required for full functionality. Network access was unavailable to inspect the full series; verify that all dependent patches from the talosaudio-v3 series are either already in the target branch or included in this PR.

---

qcom-next Presence

Commit	Status
arm64: dts: qcom: talos: Add memory-region for audio PD	⏭️ Skipped — network access unavailable; verify manually with git log --oneline --grep="talos: Add memory-region for audio PD" against qcom-next

---

Issues Found

1. ❌ Missing semicolon in DTS node (diff correctness / syntax error)

   The adsp-rpc-remote-heap reserved-memory node is terminated with } instead of };. Every DTS node must end with };. This is a hard syntax error confirmed by the dtb-check CI job (talos.dtsi:704.2-3 syntax error — FATAL ERROR: Unable to parse input tree).

   Patch as submitted (broken):

   +		adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap {
   +			compatible = "shared-dma-pool";
   +			alloc-ranges = <0x0 0x80000000 0x0 0x80000000>;
   +			reusable;
   +			alignment = <0x0 0x400000>;
   +			size = <0x0 0x800000>;
   +		}        ← missing semicolon
    	};
   

   Required fix:

   +		adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap {
   +			compatible = "shared-dma-pool";
   +			alloc-ranges = <0x0 0x80000000 0x0 0x80000000>;
   +			reusable;
   +			alignment = <0x0 0x400000>;
   +			size = <0x0 0x800000>;
   +		};       ← semicolon added
    	};
   

   This defect is likely a divergence from the lore upstream patch (which presumably has the correct };). The lore thread could not be fetched to confirm, but the upstream patch almost certainly does not contain this syntax error.

---

Recommendation

Do not merge. The patch introduces a hard DTS syntax error (} → }; missing on the adsp-rpc-remote-heap node closing brace) that breaks DTB compilation for all SoCs that include talos.dtsi. The author should amend the commit to add the missing semicolon, verify the fix matches the lore v3 posting exactly, and re-push. Additionally, confirm whether the talosaudio-v3 series has sibling patches that must accompany this one.

---

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/all/20260424-talosaudio-v3-1-9e2ad5d78a2e@oss.qualcomm.com/
2. Lore link matches PR commits: No — the PR diff contains a DTS syntax error (missing };) that is almost certainly absent from the lore upstream; direct comparison was blocked by network restrictions
3. Upstream patch status: ⏳ Decision Pending (unknown) — lore thread unreachable; patch is revision v3 of a series posted 2026-04-24; no merge or NAK signal could be verified
4. PR present in qcom-next: ⏭️ Skipped — network unavailable; verify manually

[knaveen-qc]

PR #596 — checker-log-analyzer

PR: #596
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26082070836

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings — clean
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings — skipped
dtb-check	❌	DTS syntax error in talos.dtsi:704 — missing ; after new node
sparse-check	⏭️	No C/H changes — skipped
check-uapi-headers	⏭️	No C/H changes — skipped
check-patch-compliance	❌	Content mismatch vs. lore Link + author mismatch
tag-check	✅	Single commit carries FROMLIST: prefix — valid

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD (#596)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26082070836
Target branch: qcom-6.18.y (subject-prefix check is mandatory)

Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings — clean
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings — skipped
dtb-check	❌	DTS syntax error in talos.dtsi:704 — missing ; after new node
sparse-check	⏭️	No C/H changes — skipped
check-uapi-headers	⏭️	No C/H changes — skipped
check-patch-compliance	❌	Content mismatch vs. lore Link + author mismatch
tag-check	✅	Single commit carries FROMLIST: prefix — valid

---

❌ dtb-check

Root cause: The new adsp-rpc-remote-heap DTS node added to talos.dtsi is missing a trailing semicolon (} instead of };), causing a fatal DTS parse error at line 704 that prevents all talos-derived DTBs from building.

Failure details:

Error: ../arch/arm64/boot/dts/qcom/talos.dtsi:704.2-3 syntax error
FATAL ERROR: Unable to parse input tree
make[4]: *** [../scripts/Makefile.dtbs:132: arch/arm64/boot/dts/qcom/qcs615-ride.dtb] Error 1
Log Summary: Test failed

Root cause in the patch (pr.patch line 32):

-		}
+		};

The adsp-rpc-remote-heap node closes with } but DTS requires }; to terminate a node.

Fix:

git rebase -i 6964936c9bfc   # mark dddb69a8a240 as 'edit'
# In arch/arm64/boot/dts/qcom/talos.dtsi, change:
#   }          →   };
# for the adsp-rpc-remote-heap node closing brace
git add arch/arm64/boot/dts/qcom/talos.dtsi
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs615-ride.dtb

---

❌ check-patch-compliance

Root cause: Two sub-checks failed for commit dddb69a8a240 ("FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD"):

1. Content mismatch — the diff in the PR differs from the patch at the lore Link: URL (https://lore.kernel.org/all/20260424-talosaudio-v3-1-9e2ad5d78a2e@oss.qualcomm.com/). The missing ; is the likely delta — the upstream patch presumably has the correct };.
2. Author mismatch — the upstream patch author is Ekansh Gupta <ekansh.gupta@oss.qualcomm.com> but the commit author is Jianping Li <jianping.li@oss.qualcomm.com>.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD
Change is different from the one mentioned in Link
Author mismatch:
  Original author: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
  Commit author : Jianping Li <jianping.li@oss.qualcomm.com>

Fix:

For the content mismatch: fix the }; syntax error (see dtb-check fix above) — this will likely resolve the diff delta vs. upstream.

For the author mismatch: the original patch was authored by Ekansh Gupta. Either:

• Restore the original author and add Signed-off-by: Jianping Li as a co-signer/submitter:

  git rebase -i 6964936c9bfc   # mark commit as 'edit'
  git commit --amend --author="Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>"
  # Ensure Signed-off-by lines include both authors if Jianping Li made changes
  git rebase --continue

• Or, if Jianping Li is the legitimate author of this adaptation, verify whether the lore patch is a different version and update the Link: to point to the correct revision.

Reproduce locally:

b4 am --single-message -C -l -3 \
  https://lore.kernel.org/all/20260424-talosaudio-v3-1-9e2ad5d78a2e@oss.qualcomm.com/ \
  -o /tmp/out
diff <(git format-patch -1 dddb69a8a240 --stdout | awk '/^diff/,/^--$/' | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/out/*.mbx | grep -E '^[+-][^+-]')

---

Verdict

2 blockers to fix before merge:

1. DTS syntax error — add missing ; to close the adsp-rpc-remote-heap node in arch/arm64/boot/dts/qcom/talos.dtsi (fixes both dtb-check and likely the content-mismatch in check-patch-compliance).
2. Author mismatch — align commit author with the upstream lore patch author (Ekansh Gupta) or update the Link: to the correct revision if this is a re-authored adaptation.

[shashim-quic]

Overall the change looks correct, but there is a DTS syntax error that needs to be fixed before merging (see inline comment).

[shashim-quic]

Missing semicolon: DTS node closing brace must be }; not }. This will cause a dtc compilation error.

Suggested change

	}
	};

[knaveen-qc]

PR #596 — validate-patch

PR: #596

Verdict	Issues	Detailed Report
❌	0	Full report

Verdict: ❌ — click to expand

🔍 Patch Validation

PR: FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD (#596)
Upstream: https://lore.kernel.org/all/20260424-talosaudio-v3-1-9e2ad5d78a2e@oss.qualcomm.com/
Verdict: ❌ FAIL

---

Commit Message

Check	Status	Note
Subject matches upstream	✅	FROMLIST: prefix correctly prepended; subject line matches lore message-ID subject
Body preserves rationale	✅	Body faithfully describes memory reservation and VMID list purpose
Fixes tag present/correct	N/A	Feature addition — no Fixes: tag required
Authorship preserved	✅	FROMLIST: rule: submitter is legitimately in From:; lore author Jianping Li <jianping.li@oss.qualcomm.com> is present in Signed-off-by:
Backport note (if applicable)	N/A	Not a backport
Co-developed-by used correctly	N/A	No Co-developed-by: present

---

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/talos.dtsi (include hunk)	✅	#include <dt-bindings/firmware/qcom,scm.h> correctly added — required for QCOM_SCM_VMID_LPASS and QCOM_SCM_VMID_ADSP_HEAP macros
arch/arm64/boot/dts/qcom/talos.dtsi (reserved-memory hunk)	❌	adsp-rpc-remote-heap node closes with } instead of }; — hard DTS syntax error
arch/arm64/boot/dts/qcom/talos.dtsi (fastrpc hunk)	✅	memory-region and qcom,vmids properties correctly added to the adsp fastrpc node

---

Upstream Patch Status

Commit	Community Verdict
arm64: dts: qcom: talos: Add memory-region for audio PD	⏳ Decision Pending (unknown) — lore.kernel.org unreachable from this environment; message-ID encodes v3-1 (revision 3, patch 1 of a series posted 2026-04-24); no merge or NAK signal could be verified

---

qcom-next Presence

Commit	Status
arm64: dts: qcom: talos: Add memory-region for audio PD	⏭️ Skipped — network unavailable; verify manually: git log --oneline --grep="talos: Add memory-region for audio PD" against qcom-next

---

Issues

1. ❌ Missing semicolon on DTS node closing brace (syntax error)

   The adsp-rpc-remote-heap reserved-memory node is terminated with } instead of };. This is a hard DTS syntax error that prevents DTB compilation for every SoC that includes talos.dtsi.

   As submitted (broken):

   +		adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap {
   +			compatible = "shared-dma-pool";
   +			alloc-ranges = <0x0 0x80000000 0x0 0x80000000>;
   +			reusable;
   +			alignment = <0x0 0x400000>;
   +			size = <0x0 0x800000>;
   +		}        ← missing semicolon
    	};

   Required fix:

   +		adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap {
   +			compatible = "shared-dma-pool";
   +			alloc-ranges = <0x0 0x80000000 0x0 0x80000000>;
   +			reusable;
   +			alignment = <0x0 0x400000>;
   +			size = <0x0 0x800000>;
   +		};       ← semicolon required
    	};

   This defect is almost certainly a divergence from the lore upstream patch (which would not contain a syntax error). The lore thread could not be fetched to confirm directly due to network restrictions.

2. ⚠️ Series dependency — sibling patches may be required

   The message-ID 20260424-talosaudio-v3-1-9e2ad5d78a2e@oss.qualcomm.com encodes v3-1, indicating this is patch 1 of a multi-patch series. Sibling patches (e.g. patch 2+) may introduce the audio PD driver or related DT bindings that this DTS node depends on. Verify that all patches from the talosaudio-v3 series are either already in the target branch or included in this PR.

3. ℹ️ This is an amended re-push of a previously failing commit

   Compared to the prior CI run (GHA run 26082070836), the author amended the commit (dddb69a8 → ee580bfe) to add the missing #include <dt-bindings/firmware/qcom,scm.h>. That fix is correct. However, the }; syntax error was not corrected in this amendment and remains present.

---

Verdict

Do not merge. The patch still contains a hard DTS syntax error — the adsp-rpc-remote-heap reserved-memory node closes with } instead of }; — which breaks DTB compilation for all SoCs including talos.dtsi. The author should amend the commit to add the missing semicolon, verify the corrected diff matches the lore v3 posting exactly, and re-push.

---

Final Summary

1. Lore link present: Yes — https://lore.kernel.org/all/20260424-talosaudio-v3-1-9e2ad5d78a2e@oss.qualcomm.com/
2. Lore link matches PR commits: No — the PR diff contains a DTS syntax error (missing }; on node closing brace) that is almost certainly absent from the lore upstream; direct comparison was blocked by network restrictions
3. Upstream patch status: ⏳ Decision Pending (unknown) — lore thread unreachable; patch is revision v3 of a series posted 2026-04-24; no merge or NAK signal could be verified
4. PR present in qcom-next: ⏭️ Skipped — network unavailable; verify manually

[knaveen-qc]

PR #596 — checker-log-analyzer

PR: #596
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26088051262

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings — clean
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings — skipped
dtb-check	❌	Syntax error in talos.dtsi:705 — missing semicolon introduced by PR
sparse-check	⏭️	No C/H changes — skipped
check-uapi-headers	⏭️	No UAPI changes — skipped
check-patch-compliance	❌	Content mismatch vs lore link + author mismatch
tag-check	✅	Commit subject starts with FROMLIST: — valid prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD (#596)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26088051262
Target branch: qcom-6.18.y (not qcom-next / qcom-next-staging → tag-check is mandatory)

Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings — clean
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings — skipped
dtb-check	❌	Syntax error in talos.dtsi:705 — missing semicolon introduced by PR
sparse-check	⏭️	No C/H changes — skipped
check-uapi-headers	⏭️	No UAPI changes — skipped
check-patch-compliance	❌	Content mismatch vs lore link + author mismatch
tag-check	✅	Commit subject starts with FROMLIST: — valid prefix

---

❌ dtb-check

Root cause: The PR adds a adsp-rpc-remote-heap node to talos.dtsi without a terminating semicolon after the closing }, causing a DTS syntax error at line 705.

Failure details:

Error: ../arch/arm64/boot/dts/qcom/talos.dtsi:705.2-3 syntax error
Log Summary: Test failed

The diff in pr.patch shows the new node ends with } but is missing the required ;:

+		adsp_rpc_remote_heap_mem: adsp-rpc-remote-heap {
+			compatible = "shared-dma-pool";
+			alloc-ranges = <0x0 0x80000000 0x0 0x80000000>;
+			reusable;
+			alignment = <0x0 0x400000>;
+			size = <0x0 0x800000>;
+		}          ← missing semicolon here
 	};

Fix:

git rebase -i <base_sha>   # mark commit ee580bfe as 'edit'
# In arch/arm64/boot/dts/qcom/talos.dtsi, change:
#     }
# to:
#     };
# for the adsp-rpc-remote-heap node closing brace
git add arch/arm64/boot/dts/qcom/talos.dtsi
git commit --amend --no-edit
git rebase --continue

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/talos.dtb

---

❌ check-patch-compliance

Root cause: The commit's diff differs from the upstream lore patch at the linked URL, and the commit author (Jianping Li) does not match the original patch author (Ekansh Gupta).

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: talos: Add memory-region for audio PD
Change is different from the one mentioned in Link
Author mismatch:
  Original author: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
  Commit author : Jianping Li <jianping.li@oss.qualcomm.com>

The Link: in the commit points to:
https://lore.kernel.org/all/20260424-talosaudio-v3-1-9e2ad5d78a2e@oss.qualcomm.com/

Fix — two issues to resolve:

1. Content mismatch — fetch the upstream patch and compare:

   b4 am --single-message -C -l -3 \
     https://lore.kernel.org/all/20260424-talosaudio-v3-1-9e2ad5d78a2e@oss.qualcomm.com/ \
     -o /tmp/out
   diff <(git format-patch -1 ee580bfe --stdout | awk '/^diff/,/^--$/' | grep -E '^[+-][^+-]') \
        <(awk '/^diff/,/^--$/' /tmp/out/*.mbx | grep -E '^[+-][^+-]')

   The missing semicolon (see dtb-check above) is likely the source of the content difference — the upstream patch almost certainly has }; not }. Fix the semicolon and the content mismatch should resolve.

2. Author mismatch — the commit was submitted by Jianping Li but the original patch on lore was authored by Ekansh Gupta. Fix with:

   git rebase -i <base_sha>   # mark commit as 'edit'
   git commit --amend --author="Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>"
   git rebase --continue

   If Jianping Li is the submitter/porter, add a Co-developed-by: or Signed-off-by: trailer for them, but the From: author must match the original patch author.

---

Verdict

2 blockers to fix before merge:

1. talos.dtsi:705 syntax error — add the missing ; after the adsp-rpc-remote-heap node's closing }.
2. Author mismatch — set commit author to Ekansh Gupta <ekansh.gupta@oss.qualcomm.com> (the original lore patch author); the content mismatch in check-patch-compliance will likely also resolve once the semicolon is corrected.

Both fixes can be done in a single git commit --amend after correcting the DTS file and the author field.