Skip to content

Add Kaanapali GPU qfprom node and cooling#1189

Closed
shivrawa wants to merge 0 commit into
qualcomm-linux:tech/all/dt/kaanapalifrom
shivrawa:tech/all/dt/kaanapali
Closed

Add Kaanapali GPU qfprom node and cooling#1189
shivrawa wants to merge 0 commit into
qualcomm-linux:tech/all/dt/kaanapalifrom
shivrawa:tech/all/dt/kaanapali

Conversation

@shivrawa
Copy link
Copy Markdown

Add the qfprom node and gpu related subnodes on Kaanapali SoC.

Unlike the CPU, the GPU does not throttle its speed automatically when it reaches high temperatures. Set up GPU cooling by throttling the GPU speed when reaching 105°C.

@qcomlnxci qcomlnxci requested review from a team, knaveen-qc, quicAspratap and rrnayak and removed request for a team May 19, 2026 16:10
@shivrawa shivrawa changed the title Add Kaanapli GPU qfprom node and cooling Add Kaanapali GPU qfprom node and cooling May 20, 2026
@yijiyang yijiyang force-pushed the tech/all/dt/kaanapali branch from 7436a08 to 827f315 Compare May 20, 2026 06:21
@shivrawa shivrawa force-pushed the tech/all/dt/kaanapali branch from fdb403f to 7436a08 Compare May 20, 2026 07:09
@shivrawa shivrawa closed this May 20, 2026
@shivrawa shivrawa force-pushed the tech/all/dt/kaanapali branch from 7436a08 to 827f315 Compare May 20, 2026 07:09
@qcomlnxci qcomlnxci requested a review from a team May 20, 2026 07:13
@qlijarvis
Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1189

PR: #1189
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26147553962

# Error File:Line PR-introduced? Root Cause
1 CONFLICT (content): Merge conflict — automatic merge failed arch/arm64/boot/dts/qcom/kaanapali.dtsi Yes PR branch tech/all/dt/kaanapali modifies kaanapali.dtsi (adds qfprom + GPU cooling nodes) in a region that conflicts with a concurrent change already present in the qcom-next baseline tag 9f3cbcbfaa5a143d339bcabf1a6a6ac98107e084; ci-merge cannot auto-resolve the content conflict

Note: pr.patch was empty (0 bytes) in the workspace, so cross-referencing was performed against the PR description captured in the build log ("Add the qfprom node and gpu related subnodes on Kaanapali SoC … GPU cooling by throttling the GPU speed when reaching 105°C") and the conflicting file name reported by git.

Verdict

All 1 failure is introduced by this PR: the tech/all/dt/kaanapali topic branch touches kaanapali.dtsi in a region that has diverged from the current qcom-next baseline, causing a content merge conflict that blocks both the default and RT build jobs before any compiler is ever invoked.

📎 Detailed analysis: Full report

@qlijarvis
Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1189

PR: #1189
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26147553962

# Error File:Line PR-introduced? Root Cause
1 CONFLICT (content): Merge conflict arch/arm64/boot/dts/qcom/kaanapali.dtsi Yes PR branch tech/all/dt/kaanapali cannot be auto-merged onto baseline qcom-next @ 9f3cbcbfaa5a — both sides modified the same region of kaanapali.dtsi

Verdict

The single failure is a merge conflict introduced by this PR: the topic branch tech/all/dt/kaanapali modifies arch/arm64/boot/dts/qcom/kaanapali.dtsi in a region that has also been changed on the qcom-next baseline since the PR was last rebased, causing the CI ci-merge integration step to abort before any compilation is attempted. Both the standard build job (build / build) and the RT variant (build_rt / build) hit the identical conflict.

📎 Detailed analysis: Full report

@qlijarvis
Copy link
Copy Markdown

PR #1189 — validate-patch

PR: #1189

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — the PR description contains no lore.kernel.org URL in any accepted form; pr.patch is also empty so commit messages could not be inspected
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — cannot determine; no lore link, no patch content, and no commit prefix to classify the change
  4. PR present in qcom-next: Not checked — pr.patch is empty and network access to qualcomm-linux/kernel is unavailable in this environment; the local mirror at /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel was not accessible
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: Add qfprom node and GPU cooling subnodes on Kaanapali SoC — PR #1189 (qualcomm-linux/kernel-topics)
Upstream commit: N/A — no lore.kernel.org link found
Verdict: ❌ FAIL


Step 1 — Lore Link Check

CoT reasoning: The PR description (captured from the GitHub API in the CI build log) reads:

"Add the qfprom node and gpu related subnodes on Kaanapali SoC.

Unlike the CPU, the GPU does not throttle its speed automatically when it reaches high temperatures. Set up GPU cooling by throttling the GPU speed when reaching 105°C."

No lore.kernel.org URL is present in any form (Link:, Patch-mainline:, bare URL). No commit prefix (FROMLIST:, UPSTREAM:, BACKPORT:, FROMGIT:, QCLINUX:, PENDING:, WORKAROUND:) is present in the subject line. The pr.patch file is 0 bytes — the patch was not captured by the CI workflow, so individual commit messages could not be inspected directly.

PR changes file: arch/arm64/boot/dts/qcom/kaanapali.dtsi
Lore link found: None

Per the skill's Step 1 bail-out rule: no lore link → FAIL verdict.


Commit Message

Check Status Note
Subject carries required prefix No FROMLIST:/UPSTREAM:/BACKPORT:/QCLINUX: prefix found; PR targets tech/all/dt/kaanapali (not qcom-next), so prefix is mandatory
Body preserves rationale ⚠️ PR description body is present but is prose only — no structured commit message
Fixes tag present/correct No Fixes: tag (may be N/A for a new-feature DT addition, but cannot confirm without patch)
Authorship preserved Cannot verify — pr.patch is empty; no From:/Author: or Signed-off-by: visible
Lore Link: tag Absent — required for any non-QCLINUX:/PENDING:/WORKAROUND: commit
Backport note (if applicable) N/A Cannot determine prefix type

Diff

File Status Notes
arch/arm64/boot/dts/qcom/kaanapali.dtsi pr.patch is 0 bytes — diff content unavailable; cannot compare against any upstream source

Issues

  1. No lore.kernel.org link — The PR description and commit message(s) contain no Link: https://lore.kernel.org/... tag. For a tech/all/dt/kaanapali topic branch, every commit must carry a valid prefix and, for FROMLIST:/UPSTREAM:/BACKPORT:/FROMGIT: commits, a corresponding lore link.
  2. No commit subject prefix — The subject line visible in the PR description ("Add the qfprom node and gpu related subnodes on Kaanapali SoC") carries no required prefix (FROMLIST:, UPSTREAM:, BACKPORT:, FROMGIT:, QCLINUX:, PENDING:, or WORKAROUND:). This is a mandatory requirement for all commits targeting branches other than qcom-next/qcom-next-staging.
  3. Empty pr.patch — The patch file was not captured by the CI workflow (0 bytes). Diff-level validation (hunk comparison, authorship, Signed-off-by: chain) is therefore impossible.
  4. Merge conflict blocks all checkers — All six checker jobs (checkpatch, check-patch-compliance, dtb-check, dt-binding-check, sparse-check, check-uapi-headers) failed at the ci-merge step with CONFLICT (content): Merge conflict in arch/arm64/boot/dts/qcom/kaanapali.dtsi before any patch-level analysis could run.

Verdict

Do not merge — the PR is missing a required commit subject prefix and a Link: tag pointing to a lore.kernel.org posting; additionally, the branch is out-of-date with the qcom-next baseline causing a merge conflict that must be resolved before any validation can proceed.


Final Summary

  1. Lore link present: No — the PR description contains no lore.kernel.org URL in any accepted form; pr.patch is also empty so commit messages could not be inspected
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — cannot determine; no lore link, no patch content, and no commit prefix to classify the change
  4. PR present in qcom-next: Not checked — pr.patch is empty and network access to qualcomm-linux/kernel is unavailable in this environment; the local mirror at /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel was not accessible

@qlijarvis
Copy link
Copy Markdown

PR #1189 — checker-log-analyzer

PR: #1189
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26147554625

Checker Result Summary
Checker Result Summary
checkpatch Sync failed — merge conflict in kaanapali.dtsi; checker never ran
dt-binding-check Sync failed — merge conflict in kaanapali.dtsi; checker never ran
dtb-check Sync failed — merge conflict in kaanapali.dtsi; checker never ran
sparse-check Sync failed — merge conflict in kaanapali.dtsi; checker never ran
check-uapi-headers Sync failed — merge conflict in kaanapali.dtsi; checker never ran
check-patch-compliance Sync failed — merge conflict in kaanapali.dtsi; checker never ran
tag-check N/A Target branch is tech/all/dt/kaanapali (prefix check required); sync failed before commits could be inspected
qcom-next-check N/A Not applicable — target is tech/all/dt/kaanapali, not qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1189 — DT changes targeting tech/all/dt/kaanapali
Run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26147554625

Checker Result Summary
checkpatch Sync failed — merge conflict in kaanapali.dtsi; checker never ran
dt-binding-check Sync failed — merge conflict in kaanapali.dtsi; checker never ran
dtb-check Sync failed — merge conflict in kaanapali.dtsi; checker never ran
sparse-check Sync failed — merge conflict in kaanapali.dtsi; checker never ran
check-uapi-headers Sync failed — merge conflict in kaanapali.dtsi; checker never ran
check-patch-compliance Sync failed — merge conflict in kaanapali.dtsi; checker never ran
tag-check N/A Target branch is tech/all/dt/kaanapali (prefix check required); sync failed before commits could be inspected
qcom-next-check N/A Not applicable — target is tech/all/dt/kaanapali, not qcom-next

❌ All checkers — Merge Conflict During Integration Sync

Root cause: The CI sync step failed to merge topic branch topic/tech/all/dt/kaanapali onto baseline 9f3cbcbfaa5a143d339bcabf1a6a6ac98107e084 due to a content conflict in arch/arm64/boot/dts/qcom/kaanapali.dtsi, causing every checker job to abort before running.

Failure details (identical across all 6 checker jobs):

** Merging topic branch: topic/tech/all/dt/kaanapali
Auto-merging arch/arm64/boot/dts/qcom/kaanapali.dtsi
CONFLICT (content): Merge conflict in arch/arm64/boot/dts/qcom/kaanapali.dtsi
Automatic merge failed; fix conflicts and then commit the result.
Normal merge conflict for 'arch/arm64/boot/dts/qcom/kaanapali.dtsi':
  {local}: modified file
  {remote}: modified file
automerge returned non-zero; check logs for conflicts
##[error]Process completed with exit code 1.

Fix:

The PR branch (tech/all/dt/kaanapali) has diverged from the current baseline (9f3cbcbfaa5a143d339bcabf1a6a6ac98107e084) in arch/arm64/boot/dts/qcom/kaanapali.dtsi. Rebase the PR branch onto the latest baseline to resolve the conflict:

# Fetch the latest baseline
git fetch origin
git fetch <kernel-topics-remote> tech/all/dt/kaanapali

# Rebase the topic branch onto the current baseline
git checkout tech/all/dt/kaanapali
git rebase 9f3cbcbfaa5a143d339bcabf1a6a6ac98107e084
# Resolve any conflicts in arch/arm64/boot/dts/qcom/kaanapali.dtsi
git add arch/arm64/boot/dts/qcom/kaanapali.dtsi
git rebase --continue

# Force-push the rebased branch
git push --force-with-lease origin tech/all/dt/kaanapali

After the rebase, re-trigger the CI run so all checkers can actually execute.

Reproduce locally:

git checkout -b integ 9f3cbcbfaa5a143d339bcabf1a6a6ac98107e084
git merge topic/tech/all/dt/kaanapali
# Observe conflict in arch/arm64/boot/dts/qcom/kaanapali.dtsi

Verdict

1 blocker before any checker result is meaningful: the PR branch has a merge conflict in arch/arm64/boot/dts/qcom/kaanapali.dtsi against the current baseline. Rebase the topic branch to resolve the conflict and re-trigger CI — no checker (checkpatch, dtb-check, dt-binding-check, sparse, uapi, patch-compliance) produced any output because all jobs aborted at the sync step.

@qlijarvis
Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1189

PR: #1189
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26147553962

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during integration arch/arm64/boot/dts/qcom/kaanapali.dtsi No Git merge conflict when integrating topic branch topic/tech/all/dt/kaanapali with baseline 9f3cbcbfaa5a143d339bcabf1a6a6ac98107e084

Verdict

This is not a compilation error. The build failed during the pre-build integration phase due to a merge conflict in arch/arm64/boot/dts/qcom/kaanapali.dtsi. The conflict is between the PR branch and the baseline, indicating overlapping changes that require manual resolution.

📎 Detailed analysis: Full report

@qlijarvis
Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1189

PR: #1189
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26147553962

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during integration arch/arm64/boot/dts/qcom/kaanapali.dtsi N/A Git merge conflict when integrating topic branch topic/tech/all/dt/kaanapali with baseline 9f3cbcbfaa5a143d339bcabf1a6a6ac98107e084. Both local and remote modified the same file.

Verdict

This is not a compilation failure. The build failed during the pre-build integration phase due to a merge conflict in arch/arm64/boot/dts/qcom/kaanapali.dtsi. No compilation was attempted.

📎 Detailed analysis: Full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants