PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block

[jiegan0107]

Add the following devices that are part of the APSS debug block to enable debug features, including ETM, replicator, funnel, and TMC ETF.

[sgaud-quic]

PR #1168 — validate-patch

PR: #1168

Verdict	Issues	Detailed Report
❌	0	Full report

Verdict: ❌ — click to expand

Patch Validation Report

PR: PR #1168 — PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block
Upstream: (none — PENDING: prefix)
Verdict: ❌ FAIL (validation not applicable)

Commit Message

Check	Status	Note
Subject matches upstream	N/A	PENDING: prefix — no upstream posting exists
Body preserves rationale	N/A	Vendor-only work-in-progress
Fixes tag present/correct	N/A	Not applicable for PENDING:
Authorship preserved	✅	Signed-off-by matches From: (Jie Gan)
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/glymur-staging.dtso	N/A	Cannot compare — no lore upstream to diff against

Upstream Patch Status

Commit	Community Verdict
PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block	⏳ Decision Pending — PENDING: prefix indicates patch has not been posted to any mailing list yet

qcom-next Presence

Commit	Status
PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block	⏭️ Skipped — PENDING: commits are not expected in qcom-next

Issues Found

1. No lore.kernel.org link — The PENDING: prefix explicitly signals this patch has not been posted upstream. This is by design and not an error per se, but it means lore-based validation is impossible.
2. Staging file target — The patch modifies glymur-staging.dtso, which is appropriate for work-in-progress Coresight DT additions that are not yet ready for upstream submission.

Recommendation

This commit carries the PENDING: prefix, which by convention means it is vendor-internal work-in-progress with no upstream lore equivalent. Lore-based diff validation is not applicable. The patch itself adds 1,235 lines of Coresight topology (18 ETMs, 9 replicators, 9 funnels, 3 TMC ETFs, 1 APSS funnel) to the glymur staging overlay. Before promoting this to FROMLIST:, the author should post the series to the appropriate mailing list (linux-arm-msm / coresight maintainers) and update the prefix to FROMLIST: with a Link: tag.

Final Summary

1. Lore link present: No — PENDING: prefix; no lore.kernel.org link found or expected
2. Lore link matches PR commits: N/A — validation skipped for PENDING: commits by skill design
3. Upstream patch status: ⏳ Decision Pending — patch has not been posted to any mailing list; vendor-internal WIP
4. PR present in qcom-next: ⏭️ Skipped — PENDING: commits are not tracked in qcom-next

[sgaud-quic]

PR #1168 — checker-log-analyzer

PR: #1168
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26020223968

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	All 4 commits clean — 0 errors, 0 warnings
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	✅	No new DTB errors introduced by PR (diff vs base is empty)
sparse-check	⏭️	No C/H file changes — skipped
check-uapi-headers	⏭️	No C/H file changes — skipped
check-patch-compliance	❌	All 4 commits use PENDING: prefix — not in allowed list
tag-check	✅	PENDING: is a valid tag-check prefix for tech/overlay/dt
qcom-next-check	N/A	Not a qcom-next / qcom-next-staging target

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block — #1168
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26020223968
Target branch: tech/overlay/dt (not qcom-next / qcom-next-staging → prefix check applies)

Checker	Result	Summary
checkpatch	✅	All 4 commits clean — 0 errors, 0 warnings
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	✅	No new DTB errors introduced by PR (diff vs base is empty)
sparse-check	⏭️	No C/H file changes — skipped
check-uapi-headers	⏭️	No C/H file changes — skipped
check-patch-compliance	❌	All 4 commits use PENDING: prefix — not in allowed list
tag-check	✅	PENDING: is a valid tag-check prefix for tech/overlay/dt
qcom-next-check	N/A	Not a qcom-next / qcom-next-staging target

---

❌ check-patch-compliance

Root cause: All 4 commits use the PENDING: prefix, which check-patch-compliance does not accept — it is a known checker limitation for vendor-only / not-yet-posted commits.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: hamoa: add TGU in staging dtso
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: sm8750: add TGU in staging dtso
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: kaanapali: add TGU in staging dtso
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block
Commit summary does not start with a required prefix

##[error]Process completed with exit code 1.

Fix options (choose one per commit):

Scenario	Action
Patch has been posted to lore.kernel.org	Change prefix to FROMLIST: and add Link: <lore-url> to commit body
Patch is in a maintainer tree but not yet in Linus's tree	Change prefix to FROMGIT: and add Link: <git-url>
Patch is vendor-only with no upstream equivalent	Change prefix to QCLINUX: — note: check-patch-compliance will still fail for QCLINUX: commits; this is a known checker limitation
Patch is genuinely not yet posted upstream	Keep PENDING: — this failure is expected and is a known checker limitation; no patch change needed if the intent is to track it as pending

Fix command (if changing prefix):

git rebase -i <base_sha>   # mark each commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: hamoa: add TGU in staging dtso"
git rebase --continue
# repeat for each commit

Reproduce locally:

bash kernel-checkers/check-patch-compliance.sh \
  --kernel-src ./kernel \
  --base 9f3cbcbfaa5a143d339bcabf1a6a6ac98107e084 \
  --head df9734c7d5f3e4d89c8617e2f6f82e453df944fe

---

Verdict

1 blocker: check-patch-compliance fails on all 4 commits due to the PENDING: prefix. This is a known checker limitation — PENDING: is intentionally not in the compliance checker's allowed list. If these patches are genuinely pending (not yet posted upstream), the failure is expected and can be waived. If any of the patches have since been posted to lore, update those commits to FROMLIST: + Link: to clear the failure.

[knaveen-qc]

PR #1168 — validate-patch

PR: #1168

Verdict	Issues	Detailed Report
N/A	0	Full report

Verdict: N/A — click to expand

🔍 Patch Validation

PR: PR #1168 — PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block
Upstream commit: N/A — PENDING: prefix; no lore.kernel.org link present or expected
Verdict: ⏭️ N/A (validation not applicable)

Commit Message

Check	Status	Note
Subject matches upstream	⏭️ N/A	PENDING: — no upstream posting exists
Body preserves rationale	✅	Brief but adequate: names ETM, replicator, funnel, TMC ETF
Fixes tag present/correct	⏭️ N/A	Not a bug-fix commit; no Fixes: tag required
Authorship preserved	✅	Single author Jie Gan <jie.gan@oss.qualcomm.com> with matching Signed-off-by:
Backport note (if applicable)	⏭️ N/A	Not a backport

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/glymur-staging.dtso	⏭️ N/A	No upstream lore patch to compare against; diff is self-contained (+1250 lines)

Upstream Patch Status

Commit	Community Verdict
PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block	⏭️ N/A — PENDING: prefix indicates work-in-progress not yet posted to any mailing list

qcom-next Presence

Commit	Status
arm64: dts: qcom: glymur: add Coresight devices for APSS debug block	⏭️ Skipped — PENDING: commits are not expected in qcom-next

Issues

• None from a commit-message or authorship perspective. The PENDING: prefix is used correctly for a vendor-only, not-yet-upstreamed DTS addition.

Verdict

PENDING: commits have no upstream lore link by design — lore-based validation is not applicable; the commit message and authorship are well-formed and no action is required from a patch-integrity standpoint. When this patch is ready for upstream submission, the prefix should be changed to FROMLIST: and a Link: tag pointing to the lore.kernel.org posting should be added.

[knaveen-qc]

PR #1168 — checker-log-analyzer

PR: #1168
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26073041244

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	All 4 commits clean — 0 errors, 0 warnings, 0 checks
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings — skipped
dtb-check	✅	Log Summary: Test passed — no new DTB errors introduced
sparse-check	⏭️	No C/H file changes — skipped
check-uapi-headers	⏭️	No C/H file changes — skipped
check-patch-compliance	❌	All 4 commits use PENDING: prefix — not in the allowed list
tag-check	✅	All commits carry PENDING: — valid prefix for tech/overlay/dt branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block — #1168
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26073041244

Checker	Result	Summary
checkpatch	✅	All 4 commits clean — 0 errors, 0 warnings, 0 checks
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings — skipped
dtb-check	✅	Log Summary: Test passed — no new DTB errors introduced
sparse-check	⏭️	No C/H file changes — skipped
check-uapi-headers	⏭️	No C/H file changes — skipped
check-patch-compliance	❌	All 4 commits use PENDING: prefix — not in the allowed list
tag-check	✅	All commits carry PENDING: — valid prefix for tech/overlay/dt branch

---

❌ check-patch-compliance

Root cause: All 4 commits use the PENDING: subject prefix, which check-patch-compliance does not accept — it is a known checker limitation for vendor-only / not-yet-posted commits.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: hamoa: add TGU in staging dtso
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: sm8750: add TGU in staging dtso
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: kaanapali: add TGU in staging dtso
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block
Commit summary does not start with a required prefix

##[error]Process completed with exit code 1.

Fix options (choose one per commit):

Situation	Action
Patch has been posted to lore.kernel.org	Change prefix to FROMLIST: and add Link: <lore-url> to the commit body
Patch is in a maintainer git tree	Change prefix to FROMGIT: and add Link: <tree-url>
Patch is vendor-only, will never go upstream	Keep PENDING: — this checker failure is a known limitation and cannot be resolved without an upstream posting

If the patches are genuinely not yet posted upstream, the PENDING: prefix is correct and this failure is expected/unavoidable. No patch change is needed; the reviewer/maintainer should waive this checker result.

If any of the patches have since been posted to the mailing list, update those commits:

git rebase -i <base_sha>   # mark the commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: <board>: <description>"
# add to commit body:
# Link: https://lore.kernel.org/r/<message-id>
git rebase --continue

Reproduce locally:

bash kernel-checkers/check-patch-compliance.sh \
  --kernel-src <kernel-path> \
  --base 9f3cbcbfaa5a143d339bcabf1a6a6ac98107e084 \
  --head <head-sha>

---

Verdict

1 checker failure, known limitation: check-patch-compliance fails because all 4 commits carry PENDING: — a prefix that is valid for the tech/overlay/dt branch but not accepted by the compliance checker. If these patches are genuinely not yet posted upstream, this failure is expected and the result should be waived by the maintainer. If any patches have been posted to lore, update those commits to FROMLIST: + Link: to clear the failure.

[knaveen-qc]

PR #1168 — validate-patch

PR: #1168

Verdict	Issues	Detailed Report
⚠️	0	Full report

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: PR #1168 — PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block
Upstream commit: N/A — PENDING: prefix; no lore.kernel.org link present or expected
Verdict: ⚠️ PARTIAL (validation not applicable; internal hygiene notes below)

---

Commit Message

Check	Status	Note
Subject matches upstream	N/A	PENDING: prefix — no upstream posting exists
Body preserves rationale	✅	Brief but adequate: names the devices added (ETM, replicator, funnel, TMC ETF)
Fixes tag present/correct	N/A	Not a bug-fix commit; no Fixes: tag required
Authorship preserved	✅	Single author Jie Gan <jie.gan@oss.qualcomm.com> with matching Signed-off-by:
Backport note (if applicable)	N/A	Not a backport
Co-developed-by used correctly	N/A	Not present

---

Diff

File	Status	Notes
arch/arm64/boot/dts/qcom/glymur-staging.dtso	✅	1250-line addition; adds 18 ETMs, 9 replicators, 6 funnels, 3 TMC ETFs, 1 APSS funnel, and 1 tn@11200000 port extension — all self-consistent and cross-referenced via remote-endpoint labels

---

Upstream Patch Status

Commit	Community Verdict
PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block	⏳ Decision Pending — PENDING: prefix indicates work-in-progress, not yet posted to any mailing list

---

qcom-next Presence

Commit	Status
arm64: dts: qcom: glymur: add Coresight devices for APSS debug block	⏭️ Skipped — network access unavailable; verify manually

---

Issues

1. No lore link — expected for PENDING:: The PENDING: prefix explicitly signals that this patch has not been posted upstream. No Link: tag is required or expected. This is by design and is not a defect.
2. Commit body is minimal: The description names the devices but does not explain why they are added to a -staging.dtso overlay rather than the main SoC dtsi, nor does it document any known limitations or dependencies (e.g., required firmware, power-domain prerequisites). Recommend expanding the body before upstream submission.
3. -staging.dtso placement: Adding Coresight topology to a staging overlay is acceptable for in-development hardware, but the commit message should note this is intentionally staging-only until the hardware/firmware is production-ready.

---

Verdict

PENDING: commits have no upstream lore source by design — lore diff validation is not applicable; the commit message and diff are internally consistent and the authorship is correct, but the body should be expanded with rationale and staging-placement justification before the patch is promoted to FROMLIST: and posted upstream.

[knaveen-qc]

PR #1168 — checker-log-analyzer

PR: #1168
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/26085761063

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings across all 4 commits
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	⚠️	Passes overall (Log Summary: Test passed), but new reg_format + avoid_default_addr_size warnings introduced by this PR in hamoa-staging.dtso, sm8750-staging.dtso, kaanapali-staging.dtso, and glymur-staging.dtso
sparse-check	⏭️	Skipped — no C/H file changes
check-uapi-headers	⏭️	Skipped — no C/H file changes
check-patch-compliance	❌	All 4 commits fail: PENDING: prefix not in allowed list
tag-check	✅	All 4 commits carry PENDING: prefix — valid for this repo's tag policy
qcom-next-check	N/A	Target is tech/overlay/dt, not qcom-next

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block (#1168)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/26085761063

Target branch: tech/overlay/dt (not qcom-next / qcom-next-staging → tag-check is mandatory)

Checker	Result	Summary
checkpatch	✅	0 errors, 0 warnings across all 4 commits
dt-binding-check	⏭️	No changes in Documentation/devicetree/bindings
dtb-check	⚠️	Passes overall (Log Summary: Test passed), but new reg_format + avoid_default_addr_size warnings introduced by this PR in hamoa-staging.dtso, sm8750-staging.dtso, kaanapali-staging.dtso, and glymur-staging.dtso
sparse-check	⏭️	Skipped — no C/H file changes
check-uapi-headers	⏭️	Skipped — no C/H file changes
check-patch-compliance	❌	All 4 commits fail: PENDING: prefix not in allowed list
tag-check	✅	All 4 commits carry PENDING: prefix — valid for this repo's tag policy
qcom-next-check	N/A	Target is tech/overlay/dt, not qcom-next

---

❌ check-patch-compliance

Root cause: All 4 commits use the PENDING: prefix, which check-patch-compliance does not accept — it requires FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: hamoa: add TGU in staging dtso
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: sm8750: add TGU in staging dtso
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: kaanapali: add TGU in staging dtso
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: glymur: add Coresight devices for APSS debug block
Commit summary does not start with a required prefix

##[error]Process completed with exit code 1.

Fix: This is a known checker limitation for vendor-only / not-yet-posted commits. PENDING: is intentional here — these patches have not been posted upstream yet. No patch change is needed unless the patches are posted to lore, in which case change the prefix to FROMLIST: and add a Link: trailer.

Reproduce locally:

bash kernel-checkers/check-patch-compliance.sh --kernel-src <kernel> \
  --base 9f3cbcbfaa5a143d339bcabf1a6a6ac98107e084 --head <head_sha>

---

⚠️ dtb-check — New warnings from this PR (informational; overall result is PASS)

Root cause: The new TGU staging overlays (hamoa-staging.dtso, sm8750-staging.dtso, kaanapali-staging.dtso) and the Coresight overlay (glymur-staging.dtso) use a 4-cell reg property (<0x0 0xADDR 0x0 0x1000> = 16 bytes) but the parent node has #address-cells == 2, #size-cells == 1, which expects only 3 cells (12 bytes). The nodes also rely on default #address-cells/#size-cells values.

Failure details (new warnings introduced by this PR):

../arch/arm64/boot/dts/qcom/hamoa-staging.dtso:14.3-37: Warning (reg_format):
  /fragment@0/__overlay__/tgu@10b0e000:reg: property has invalid length
  (16 bytes) (#address-cells == 2, #size-cells == 1)

../arch/arm64/boot/dts/qcom/sm8750-staging.dtso:14.3-37: Warning (reg_format):
  /fragment@0/__overlay__/tgu@10b0e000:reg: property has invalid length
  (16 bytes) (#address-cells == 2, #size-cells == 1)

../arch/arm64/boot/dts/qcom/glymur-staging.dtso:14.3-37: Warning (reg_format):
  /fragment@0/__overlay__/ctcu@10001000:reg: property has invalid length
  (16 bytes) (#address-cells == 2, #size-cells == 1)

../arch/arm64/boot/dts/qcom/glymur-staging.dtso:158.15-164.4: Warning (avoid_default_addr_size):
  /fragment@0/__overlay__/tgu@11c02000: Relying on default #address-cells value

Fix: Change the reg property in the new staging overlays from 4-cell to 3-cell format to match the parent's #address-cells == 2, #size-cells == 1:

- reg = <0x0 0x10b0e000 0x0 0x1000>;
+ reg = <0x0 0x10b0e000 0x1000>;

Also add explicit #address-cells = <2>; #size-cells = <1>; to the overlay root node to suppress avoid_default_addr_size. Note: the same reg_format pattern is present in pre-existing staging files (lemans-staging.dtso, monaco-staging.dtso, kodiak-staging.dtso, talos-staging.dtso) — this is a tree-wide pattern, so the dtb-check overall result is still PASS.

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/hamoa-staging.dtbo
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/glymur-staging.dtbo

---

Verdict

1 real blocker: check-patch-compliance fails for all 4 commits due to the PENDING: prefix — this is a known checker limitation for vendor-only patches not yet posted upstream. If these patches are intentionally PENDING: (not yet sent to lore), this failure is expected and acceptable per project policy; no code change is needed.

1 informational item: dtb-check passes overall but the new TGU/Coresight staging overlays introduce reg_format and avoid_default_addr_size warnings consistent with a tree-wide pattern. Consider fixing the reg cell count in the new files to avoid accumulating technical debt.

[shashim-quic]

Add the following devices that are part of the APSS debug block to enable debug features, including ETM, replicator, funnel, and TMC ETF.

Hi @jiegan0107
IIUC some of these can be upstreamed ? Why are all of them in staging ?

[jiegan0107]

Add the following devices that are part of the APSS debug block to enable debug features, including ETM, replicator, funnel, and TMC ETF.

Hi @jiegan0107 IIUC some of these can be upstreamed ? Why are all of them in staging ?

Hi @shashim-quic, the replicator/funnel/tmc_etf devices mentioned here depends on the same driver patch series for the APSS power domain.
https://lore.kernel.org/all/20251218-cpu_cluster_component_pm-v2-0-2335a6ae62a0@oss.qualcomm.com/