fix: map Q_IP_MEASUREMENT to Q_IP_RAW_DATA dataset type#16
Merged
Conversation
QDatasetType.fromQSampleType() was missing a mapping case for Q_IP_MEASUREMENT, causing a DatasetTypeMappingException when processing IP measurement samples. The Q_IP_RAW_DATA enum constant already existed but was never wired up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When processing
Q_IP_MEASUREMENTsamples, the ETL throws:This happens because
QDatasetType.fromQSampleType()has no mapping case forQ_IP_MEASUREMENT.`Root Cause
QSampleType.Q_IP_MEASUREMENTexists (added in Add IP measurement type #12)QDatasetType.Q_IP_RAW_DATAexists as an enum constantfromQSampleType()was never wired upFix
Added the missing mapping: