dont destroy type of decorated function#432
Conversation
|
Yes, this makes sense. We are currently targeting 3.10+ |
|
This syntax should be legal also for python 3.10. It's a simple change, so hopefully linting will go thru without me setting up the test dependencies. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
+ Coverage 82.38% 82.40% +0.01%
==========================================
Files 20 20
Lines 2254 2256 +2
Branches 359 359
==========================================
+ Hits 1857 1859 +2
Misses 300 300
Partials 97 97
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
fixed a linting error from |
|
Appreciated. You don't have to satisfy the linter if its unrelated to your changes. The ty checker is probably not the best one to use on CI given how much flux it is in, but that's something to address in a different PR. This LGTM. I'll merge once the main dashboards come back green. |
Would you accept something in this direction? I've been using
line_profilera bunch and I noticed that the decorated functions fail linting withpyrightand the like, because they lose the type.I didn't setup the tests yet, and we probably have to write it more backwards compatible in case you want it to work with python 3.11 or older.