[mypyc] Add new type for expressing header dependencies#21223
Merged
p-sawicki merged 2 commits intopython:masterfrom Apr 14, 2026
Merged
[mypyc] Add new type for expressing header dependencies#21223p-sawicki merged 2 commits intopython:masterfrom
p-sawicki merged 2 commits intopython:masterfrom
Conversation
JukkaL
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #21183 to address a review comment. The external dependency of a capsule added there is really only needed to get the path of a lib-rt header that can be placed in the external header of a C extension so it doesn't make sense to use
SourceDepthat references a .c file. Instead add a newHeaderDeptype that expresses only a dependency on a header file.The header has to be included in the external C extension header because the exports table might reference types defined in lib-rt headers, like
VecTinlib-rt/vecs/librt_vecs.h. However, the external C extension header cannot include the_api.hheader added in that PR because that would leak a dependency on the associated_api.cfile which defines extern objects declared in_api.h. That would result in undefined objects when a C extension that doesn't depend on a given lib-rt module (including indirectly) imports from a C extension that does.