Skip to content

gh-148487: Fix issues in test_add_python_opts#148507

Open
StanFromIreland wants to merge 3 commits intopython:mainfrom
StanFromIreland:check_add_python_opts
Open

gh-148487: Fix issues in test_add_python_opts#148507
StanFromIreland wants to merge 3 commits intopython:mainfrom
StanFromIreland:check_add_python_opts

Conversation

@StanFromIreland
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland commented Apr 13, 2026 •
edited
Loading

Apart from the wrong skip condition, the tests needed updating post 8a00c9a.

@StanFromIreland StanFromIreland added tests Tests in the Lib/test dir skip news labels Apr 13, 2026
@bedevere-app bedevere-app bot mentioned this pull request Apr 13, 2026
Open
vstinner
vstinner reviewed Apr 13, 2026
View reviewed changes
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Apr 13, 2026

"_RegenSbom" failed with "HTTP error 503: Service Unavailable" on Windows CIs:

Download from https://www.bytereef.org/software/mpdecimal/releases/mpdecimal-2.5.1.tar.gz failed.

vstinner
vstinner approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland
Copy link
Copy Markdown
Member Author

StanFromIreland commented Apr 13, 2026

"_RegenSbom" failed with "HTTP error 503: Service Unavailable" on Windows CIs:

I can access the website now, I will try re-run.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Apr 13, 2026

Merge branch 'main' into check_add_python_opts

This action re-runs all CIs, it's not needed. I prefer to only re-run failed jobs, action available if you click on CI details (once all CI jobs completed, successfully or not).

@StanFromIreland
Copy link
Copy Markdown
Member Author

StanFromIreland commented Apr 13, 2026

This action re-runs all CIs, it's not needed. I prefer to only re-run failed jobs, action available if you click on CI details (once all CI jobs completed, successfully or not).

I can do that next time. Tests are passing, it seems the site is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@graingert graingert Awaiting requested review from graingert

Assignees

No one assigned

Labels

awaiting merge skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @vstinner