If ICO image is smaller than (16, 16), save original size by default#9766
Open
radarhere wants to merge 2 commits into
Open
If ICO image is smaller than (16, 16), save original size by default#9766radarhere wants to merge 2 commits into
radarhere wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #9745
https://pillow.readthedocs.io/en/stable/handbook/image-file-formats.html#ico-saving
If all sizes are ignored, then the file is still allowed to be saved at the moment, just without any visual content.
This PR updates the default behaviour to use the image size if it is smaller than (16, 16) in either dimension. If the user explicitly requested 'sizes', then raise a ValueError if all sizes were ignored.