Avoid divide-by-zero crash in image filtering#9755
Open
lukegb wants to merge 3 commits into
Open
Conversation
A kernel size of 1 is pointless/trivial, but it shouldn't cause the C extension to crash.
for more information, see https://pre-commit.ci
Merging this PR will not alter performance
Comparing Footnotes
|
Member
|
I've created lukegb#3 with a suggestion - rather than expand the image by zero, I think just copying the image would be more efficient. You probably want to keep |
radarhere
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Fixes a crash accidentally introduced by the validation logic added in dff01a0.