Skip to content

Reject text paths in decoded replace #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Mirochill wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Reject text paths in decoded replace #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/hyperlink/_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2265,6 +2265,10 @@ def replace(
automatically encoded instead of an error being raised.
"""
if path is not _UNSET:
if isinstance(path, Text):
raise TypeError(
"expected iterable of text for path, not: %r" % (path,)
)
path = tuple(_encode_reserved(p) for p in path)
if query is not _UNSET:
query = cast(
Expand Down
12 changes: 12 additions & 0 deletions src/hyperlink/test/test_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1023,6 +1023,18 @@ def test_technicallyTextIsIterableBut(self):
"expected iterable of text for path, not: {0}".format(repr("foo")),
)

decoded_url = URL.from_text(
"https://example.com/api/v1/webui"
).get_decoded_url()
with self.assertRaises(TypeError) as raised:
decoded_url.replace(path="support/woo")
self.assertEqual(
str(raised.exception),
"expected iterable of text for path, not: {0}".format(
repr("support/woo")
),
)

def test_netloc(self):
# type: () -> None
url = URL(scheme="https")
Expand Down