Skip to content

Fix i18n locale activation#327

Open
VladislavLysykh wants to merge 2 commits into
python-humanize:mainfrom
VladislavLysykh:main
Open

Fix i18n locale activation#327
VladislavLysykh wants to merge 2 commits into
python-humanize:mainfrom
VladislavLysykh:main

Conversation

@VladislavLysykh

Copy link
Copy Markdown

Added tests for i18n locale activation.

Changes:

  • added coverage for locale activation
  • verified translation loading
  • verified locale switching behavior

Test results:
703 passed, 69 skipped

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 15 untouched benchmarks


Comparing VladislavLysykh:main (76964bc) with main (976484a)

Open in CodSpeed

@hugovk

hugovk commented Jun 25, 2026

Copy link
Copy Markdown
Member

How is this testing locale activation? It's only testing some noop functions that don't really do anything.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.55%. Comparing base (976484a) to head (76964bc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_i18n.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          12       12           
  Lines         900      908    +8     
=======================================
+ Hits          896      904    +8     
  Misses          4        4           
Flag Coverage Δ
macos-latest 97.57% <87.50%> (+0.02%) ⬆️
ubuntu-latest 97.57% <87.50%> (+0.02%) ⬆️
windows-latest 95.70% <87.50%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants