[PULP-1496] Add repository-specific package blocklist#1187
Open
[PULP-1496] Add repository-specific package blocklist#1187
Conversation
jobselko
force-pushed
the
1166
branch
2 times, most recently
from
96b75dd to
5d9caeb
Compare
jobselko
commented
Apr 13, 2026
jobselko
commented
Apr 13, 2026
gerrod3
requested changes
Apr 14, 2026
closes pulp#1166 Assisted By: Claude Opus 4.6
gerrod3
requested changes
Apr 16, 2026
Contributor
gerrod3
left a comment
gerrod3
left a comment
There was a problem hiding this comment.
This is looking good, few more things before approval.
| if entry.filename and entry.filename == pkg.filename: | ||
| blocked.append(pkg.filename) | ||
| break | ||
| if entry.name and canonicalize_name(entry.name) == pkg.name_normalized: |
Contributor
There was a problem hiding this comment.
Suggested change
| if entry.name and canonicalize_name(entry.name) == pkg.name_normalized: | |
| if entry.name == pkg.name_normalized: |
The entry's name is normalized in the serializer.
| """ | ||
| if not content_ids: | ||
| return | ||
| packages = python_models.PythonPackageContent.objects.filter(pk__in=content_ids) |
Contributor
There was a problem hiding this comment.
Suggested change
| packages = python_models.PythonPackageContent.objects.filter(pk__in=content_ids) | |
| packages = python_models.PythonPackageContent.objects.filter(pk__in=content_ids).only("filename", "name_normalized", "version") |
Comment on lines
+89
to
+90
| def test_upload_blocked(delete_orphans_pre, monitor_task, python_bindings, python_repo): | ||
| """ |
Contributor
There was a problem hiding this comment.
Did you see problems running these tests in parallel?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1166
📜 Checklist
See: Pull Request Walkthrough