Fix UpdatePort corrupting the host when the port digits appear inside the host/IP#752
Merged
Mzack9999 merged 1 commit intoJun 22, 2026
Conversation
dogancanbakir
approved these changes
Jun 22, 2026
Mzack9999
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #753
Fix UpdatePort corrupting the host when the port digits appear inside the host/IP
Problem
URL.UpdatePortreplaced the port viastrings.Replace(u.Host, u.Port(), newport, 1),which swaps the first occurrence of the port substring in the host — not the actual
port. When the port digits also appear inside the IP/hostname, the wrong part gets rewritten.
Examples:
http://37.228.93.80:80/+UpdatePort("443")→http://37.228.93.443:80/❌http://[2001:db8::80]:80/+UpdatePort("8080")→http://[2001:db8::8080]:80/❌Fix
Build the host with
net.JoinHostPort(u.Hostname(), newport).Hostname()strips theexisting port and unwraps IPv6 brackets, and
JoinHostPortre-wraps IPv6 literalscorrectly — so the port is always set on the right segment.
Tests
Added
TestPortUpdateWhenPortMatchesHostcovering IPv4 and IPv6 cases that previouslyproduced a corrupted host.