Seedtag: adds ron id support for seedtag adapter#4466
Open
sangarbe wants to merge 1 commit into
Open
Conversation
This was referenced Apr 16, 2026
sangarbe
force-pushed
the
LN-3693-implement-ron-id-flow-in-hb-prebid-s-2-s
branch
from
aa718e9 to
c4e01b7
Compare
CTMBNara
requested changes
May 13, 2026
Comment on lines
+348
to
+351
| private static Imp givenImp(UnaryOperator<Imp.ImpBuilder> impCustomizer, ExtImpSeedtag extImpSeedtag) { | ||
| final ObjectNode bidderExt = mapper.createObjectNode(); | ||
| bidderExt.set("bidder", mapper.valueToTree(extImpSeedtag)); | ||
| return impCustomizer.apply(Imp.builder().id("123").ext(bidderExt)).build(); |
Collaborator
There was a problem hiding this comment.
Remove impCustomizer from parameters for now
Comment on lines
+34
to
+49
| @Test | ||
| public void openrtb2AuctionShouldRespondWithBidsFromSeedtagUsingPublisherIdAndRonIntegrationType() | ||
| throws IOException, JSONException { | ||
| // given | ||
| WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/seedtag-exchange")) | ||
| .withRequestBody(equalToJson(jsonFrom("openrtb2/seedtag/test-seedtag-ron-bid-request.json"))) | ||
| .willReturn(aResponse().withBody(jsonFrom("openrtb2/seedtag/test-seedtag-ron-bid-response.json")))); | ||
|
|
||
| // when | ||
| final Response response = responseFor("openrtb2/seedtag/test-auction-seedtag-ron-request.json", | ||
| Endpoint.openrtb2_auction); | ||
|
|
||
| // then | ||
| assertJsonEquals("openrtb2/seedtag/test-auction-seedtag-ron-response.json", response, | ||
| singletonList("seedtag")); | ||
| } |
Collaborator
There was a problem hiding this comment.
No need for this test. We test all logic using unit testing.
Also, remove newly added .json files for this test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Seedtag will support RON id integrations through PBS
🧠 Rationale behind the change
Seedtag needs to add the corresponding bidder parameters to indentify integrations using RON ids, while being totally backward compatible with legacy integrations
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check