chore: update dependencies#432
Conversation
![poe-code-agent[bot]](https://avatars.githubusercontent.com/in/2645587?s=60&v=4){kind=small}
| "license": "ISC", | ||
| "engines": { | ||
| "node": "^20.17.0 || >=22.9.0" | ||
| "node": "^22.22.2 || ^24.15.0 || >=26.0.0" |
There was a problem hiding this comment.
Non-blocking: npm ci on Node 20 now emits an EBADENGINE warning here because @opencode-ai/plugin@1.17.9 pulls effect@4.0.0-beta.74 → ini@7.0.0, which requires Node >=22.22.2. It still installed locally under npm 10, so I don't think this should block the lockfile refresh.
00035cb to
24c8991
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24c8991b48
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| export type RequestId = null | number | string; | ||
|
|
||
| export type StopReason = "completed" | "cancelled" | "max_tokens"; | ||
| export type StopReason = "completed" | "end_turn" | "cancelled" | "max_tokens"; |
There was a problem hiding this comment.
When an ACP v1 agent returns max_turn_requests after hitting its per-turn request cap or refusal, the client still rejects the prompt response because this union and validStopReasons exclude them. The ACP v1 schema lists end_turn, max_tokens, max_turn_requests, refusal, and cancelled as StopReason values (https://agentclientprotocol.com/protocol/v1/schema#stopreason), so this partial update still breaks valid agents in those stop paths.
Useful? React with 👍 / 👎.
Summary
kill()type with the updatede2bSDK return type.end_turnstop reason emitted by updated agents.Validation
npx vitest run packages/poe-acp-client/src/acp-client-unified.test.ts -t "accepts current ACP stopReason"npx vitest run packages/poe-acp-client/src/acp-client-unified.test.ts -t "rejects prompt responses"npm run build -w @poe-code/poe-acp-clientnpm run buildnpm run lintnpm testnpm run lint:packagesnpm testNotes
npm auditstill reports the existinggray-matter/js-yamladvisory that requires a semver-majorgray-matterdowngrade, plus anagent-stashnestedesbuildadvisory thatnpm audit fixdid not resolve within current compatible ranges.