fix(forge): stabilize ssh-connector reconnect-failure test on Windows#305
Merged
Conversation
Replace fixed 100ms sleep with vi.waitFor() polling, so the test waits for the reconnect cycle to complete rather than racing against CI timing. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forge-test (windows-latest)CI failure inssh-connector.test.ts > auto-reconnect failure logs error and reschedules instead of crashing100mssleep to wait for the reconnect cycle, but on Windows CI the10msbackoff +15mshealth timeout wasn't always complete within that window — the assertion caught the state as'connecting'instead of'failed'vi.waitFor()polling (matching the pattern already used by the recovery test below it), giving the reconnect cycle up to 500ms to settleTest plan
ssh-connector.test.ts— all 17 tests pass locallyforge-test (windows-latest)passesMade with Cursor