fix: nested array stored in DB for readonly dropdown#1197
Open
TarekRemo wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
It fixes ticket !44062.
Steps to reproduce:
Root cause:
dropdownFieldTwig macro pre-appends[]to the field name for all multiple inputs (e.g.plugin_fields_donefielddropdowns_id[]).Dropdown::show()renders hidden inputs and appends another[], producingplugin_fields_donefielddropdowns_id[][].[['3']]instead of['3']), which gets JSON-encoded as[["3"]]and stored corrupted in the database.Dropdown::show()receives the decoded nested array, iterates over it, and tries to use an array as an array key inside isset(), triggering a PHP 8 TypeError.Fix:
flattenScalars()collapses any nested arrays into a flat list of scalars, preventing the corruption from ever reaching the database.