Remove Babel from stackgl_modules build process#7906
Closed
coyaSONG wants to merge 2 commits into
Closed
Conversation
Contributor
|
Thanks for the PR! After some team discussions, I think we're going to handle this internally as there will be some architectural changes. I'm closing your PR since we'll create a new one. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
babel-loaderrules and the explicit ES5 webpack target from thestackgl_modulesbuildCloses #7862.
Impact
The stackgl vendor build now relies on webpack directly while keeping the existing
ify-loaderandraw-loaderrules. The generated bundle continues to render representative scatter3d, mesh3d, and surface figures identically to the unmodified base build.Dependabot PR #7903 updates
@babel/core, which this change removes, so this PR supersedes that dependency update if merged.Validation
npm run bundle-stackgl(Node 18.20.8 / npm 10.9.4)npm run cibuild(Node 18.20.8 / npm 10.9.4)npm run test-jasmine -- scatter3d mesh3d surface --nowatch --report-dots(61/61 passed)npm run lintnpm run test-mock -- gl3d_scatter3d-colorscale-with-line gl3d_mesh3d_coloring gl3d_surface_intensitySubmission checks
master(437cb2be78d12bfd7d1bc8bb7527bd238471314b)dist/files committedstackgl_modules/package-lock.jsonupdatedAI assistance
OpenAI Codex (GPT-5) was used to investigate the issue, implement the scoped change, and run the checks listed above. The resulting diff and test outputs were inspected before submission.