You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You use a PDF icon for Downloads, but the galleys could also be in a different format, e.g. HTML, so a more generic icon would probably better fit for that, I think.
There are some hard coded words in your smarty template -- for example "views" and "Downloads". I will suggest to put them into the locale.po file, so that they can be translated and have properly meaning in different languages.
It would be good to use _doiURLEncode function (you can find the function in the DOIPubIdPlugin.php) when displaying the DOI.
There are two functions that are not used by the plugin. They can be removed.
The certification type can be "reviewed" in your PR for the plugin_gallery.
I also think that the plugin name is a little bit too generic -- one could think that the plugin calculates some article metrics, for example -- but I still have no good suggestion for another name :-)
Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.