Skip to content

Simplify ON keyword check to only needed case#652

Open
predictor2718 wants to merge 2 commits intophpmyadmin:5.11.xfrom
predictor2718:fix/627-set-variable-on
Open

Simplify ON keyword check to only needed case#652
predictor2718 wants to merge 2 commits intophpmyadmin:5.11.xfrom
predictor2718:fix/627-set-variable-on

Conversation

@predictor2718
Copy link
Copy Markdown
Contributor

Summary

  • SET @@variable = ON failed with "Missing expression" because ON is a reserved keyword that
    Expression::parse() rejected
  • OFF worked because it is not a reserved keyword
  • Fix: in SetOperation::parse(), after Expression::parse() returns null, accept ON as a literal value since
    it is valid in SET statements

Fixes #627

Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.90%. Comparing base (4c45eac) to head (0bd40a6).

Files with missing lines Patch % Lines
src/Components/SetOperation.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             5.11.x     #652      +/-   ##
============================================
- Coverage     96.92%   96.90%   -0.02%     
- Complexity     2316     2319       +3     
============================================
  Files            71       71              
  Lines          5110     5112       +2     
============================================
+ Hits           4953     4954       +1     
- Misses          157      158       +1     
Flag Coverage Δ
unit-7.2-ubuntu-latest 96.90% <66.66%> (-0.02%) ⬇️
unit-7.3-ubuntu-latest 96.89% <66.66%> (-0.02%) ⬇️
unit-7.4-ubuntu-latest 96.87% <66.66%> (-0.02%) ⬇️
unit-8.0-ubuntu-latest 96.89% <66.66%> (-0.02%) ⬇️
unit-8.1-ubuntu-latest 96.89% <66.66%> (-0.02%) ⬇️
unit-8.2-ubuntu-latest 96.85% <66.66%> (-0.02%) ⬇️
unit-8.3-ubuntu-latest 96.85% <66.66%> (-0.02%) ⬇️
unit-8.4-ubuntu-latest 96.85% <66.66%> (-0.02%) ⬇️
unit-8.5-ubuntu-latest 96.85% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant