Fix opaque rendering of TilemapGPULayer empty cells#7336
Open
moufmouf wants to merge 1 commit into
Open
Conversation
Empty cells were not discarded in the fragment shader. getTileTexelCoord() returns (0, 0) for an empty tile, so it sampled the top-left texel of tile 0 - opaque for most tilesets - painting tile 0 over everything drawn beneath the layer. This also made stacked GPU layers hide one another: an upper layer's empty cells covered the layer below. Discard empty fragments in main() and regenerate the bundled shader. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (delete as applicable)
Empty cells were not discarded in the fragment shader.
getTileTexelCoord()returns(0, 0)for an empty tile, so it sampled the top-left texel of tile 0 (opaque for most tilesets) painting tile 0 over everything drawn beneath the layer. This also made stacked GPU layers hide one another: an upper layer's empty cells covered the layer below.Discard empty fragments in main() and regenerate the bundled shader.
You can view a repro of the error in this fork of the examples repository:
https://github.com/moufmouf/examples/blob/5ba9594ebf6a5405309cdf6e887f86980b36083d/public/src/tilemaps/tilemap%20gpu%20layer/gpu%20tile%20layer%20empty%20cells.js
Before the fix:
After the fix: