Allowlist BigONE domains#1824
Open
elioncode wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesDomain Whitelist Update
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allowlist BigONE root domains and wildcard subdomains:
bigone.com*.bigone.combig.one*.big.oneWhy
BigONE users are still being redirected by the Phantom extension to the phishing warning page for
bigone.com. The warning shown by Phantom saysbigone.com is blockedand that the website is considered malicious and unsafe to use.There is an older PR for this false-positive appeal (#1707), but it only adds wildcard entries. This PR also includes the root domains because the observed warning is triggered on
bigone.comitself.Notes for reviewers
I checked the current public
blocklist.yamland did not findbigone.comorbig.onethere. If this repository is not the active source for the current production verdict, please advise the correct appeal path or data source so the false-positive block can be removed.Validation
git diff --checkyarn install --frozen-lockfile && node ./ci.jsyarn run buildand confirmed all four BigONE entries appear in generatedblocklist.jsonwhitelist dataSummary by CodeRabbit