Add All Spaces window scope#27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cmdcmd only showed the windows on the current macOS Space. If you kept work spread across Spaces or displays, the overlay could not help you find or jump to those windows.
The both-Command-keys shortcut also felt stuck in one common case. After a clean chord fired, tapping the other Command key again while still holding one Command key did not fire again.
Solution
This PR adds a Window scope setting. The default keeps the old Current Space behavior, and the new All Spaces mode shows windows from other macOS desktops when WindowServer exposes them.
All Spaces mode opens the overlay across displays, labels windows from other Spaces, and switches to the right Space when you pick one. The Command-key shortcut can now repeat after one Command key is released, while still ignoring chords mixed with normal key presses.
Technical Summary
windowScopesetting through config generation, settings UI, and a required changeset.--self-test-cmd-chordso the repeat behavior can be checked without opening the app.