bump v6 lpm size#268
Conversation
rcgoodfellow
force-pushed
the
ry/bump-v6-lpm-table-size
branch
from
257557f to
4e43a6c
Compare
zeeshanlakhani
left a comment
zeeshanlakhani
left a comment
There was a problem hiding this comment.
Something to note is that Ingress.l3_router.Router6.lookup_idx.lookup is now split across 3 stages.
With this additional splitting of stages and size jump in general, do we expect any ramifications with other types of workloads? Otherwise, totally get the need for this bump given the issue. @Nieuwejaar chiming in would be good too.
| const int IPV6_NAT_TABLE_SIZE = 1024; // nat routing table | ||
| const int IPV4_LPM_SIZE = 8192; // ipv4 forwarding table | ||
| #ifdef MULTICAST | ||
| const int IPV6_LPM_SIZE = 1024; // ipv6 forwarding table |
There was a problem hiding this comment.
minor: obviously we'll have to update this for mcast (whether we keep the feature on or off, as it shouldn't affect everything else), but maybe putting a TODO here would help?
There was a problem hiding this comment.
Created a follow on issue
In theory no. In practice we need to run our QA suite over this across a set of ASICs in the lab. |
3 participants
Brings the V6 routing tables up to 8291 entries, in line with V4 routing tables.
Something to note is that
Ingress.l3_router.Router6.lookup_idx.lookupis now split across 3 stages.