Skip to content

docs: use correct owncloud.exe binary name for oc#762

Open
DeepDiver1975 wants to merge 1 commit into
masterfrom
fix/removing-exe-case
Open

docs: use correct owncloud.exe binary name for oc#762
DeepDiver1975 wants to merge 1 commit into
masterfrom
fix/removing-exe-case

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Member

master counterpart of #761. The regedit step searched for {bin_name}.exe (renders ownCloud.exe for oc); the actual binary is owncloud.exe (APPLICATION_EXECUTABLE is lowercase). Split with ifeval so oc shows owncloud.exe and kw keeps {bin_name}.exe.

🤖 Generated with Claude Code

The regedit search instruction used {bin_name}.exe, which renders as
ownCloud.exe for the oc build. The actual Windows binary is owncloud.exe
(APPLICATION_EXECUTABLE is lowercase). Split the step with an ifeval so
the oc variant shows owncloud.exe while kw keeps {bin_name}.exe.

Source: OWNCLOUD.cmake (APPLICATION_EXECUTABLE), src/gui/CMakeLists.txt.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975

Copy link
Copy Markdown
Member Author

Review — docs: use correct owncloud.exe binary name for oc

Verdict: Approve (review comment only — auto-merge N/A, agent-authored; GitHub blocks self-approval).

Accuracy — verified

  • The Windows desktop GUI binary for the ownCloud build is owncloud.exe. Confirmed against owncloud/client OWNCLOUD.cmake: set( APPLICATION_EXECUTABLE "owncloud" ) (lowercase).
  • The bug is real: {bin_name} renders as ownCloud for the oc build (:bin_name: ownCloud in modules/ROOT/partials/conditional_naming.adoc), so the old text documented ownCloud.exe — wrong case.
  • The kw branch correctly keeps {bin_name}.exe, which renders lowercase (:bin_name: kiteworks). Good call not hardcoding there.
  • This is the GUI taskbar-shortcut removal context, so naming the GUI binary owncloud.exe (not the CLI owncloudcmd.exe) is correct. No GUI-vs-CLI confusion.

Mechanics

  • ifeval::["{targetbuild}" == "oc"] / == "kw" split with matching endif::[] — AsciiDoc syntax is valid.
  • CI: Build documentation pass, lint pass.
  • Internally consistent; no stray owncloudcmdowncloud.exe swaps.

Notes

🤖 Automated PR review by Claude Code review agent.

@dj4oC dj4oC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splits the regedit search-string step with ifeval so the oc build shows owncloud.exe while kw keeps {bin_name}.exe, matching the master/7.1 pair (#761).

Findings

Nothing blocking. Both ifeval::[...]/endif::[] blocks are correctly opened and closed, and the pattern matches existing targetbuild conditionals used elsewhere in this repo. No broken links or formatting issues.

Verdict

Approved

🤖 Automated review by Claude Code


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants