docs: complete folder three-dots menu for oc (7.1)#757
Conversation
The oc folder Three-Dots menu was documented with a single entry, "Enable/Disable virtual file support", which does not match client 7.1. The menu actually contains: Show in Explorer, Show in web browser (capability-gated), Sync now / Restart sync, Pause sync / Resume sync, Activate / Deactivate virtual files (or Manage subfolder sync), and Remove folder sync / Remove Space sync. Rewrite the oc list accordingly and correct the VFS toggle wording. Source: src/gui/FoldersGui/accountfolderscontroller.cpp:120-247. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Review — #757 (7.1 backport)Verdict: clean (approve-equivalent). 7.1 counterpart of #758. The diff is byte-identical to the master PR, so the backport is fully consistent. The change replaces the single fictional
AsciiDoc: clean — valid CI: lint ✅. Changelog: n/a — repo has no changelog convention. Auto-merge: N/A — agent-authored (DeepDiver1975); GitHub blocks self-approval, so a human approver is required to merge. 🤖 Automated PR review by Claude Code review agent. |
dj4oC
left a comment
dj4oC
left a comment
There was a problem hiding this comment.
7.1 counterpart of #758 — same folder Three-Dots menu rewrite.
Findings
Diff matches the master PR (#758) in substance; same anchor reuse and AsciiDoc syntax checks pass. Not independently re-verified against owncloud/client source (out of scope here).
Verdict
Approved
🤖 Automated review by Claude Code
Generated by Claude Code
2 participants
Summary
The oc-brand Manage Sync Relationships section documents the folder Three Dots menu as a single entry — Enable/Disable virtual file support — but client 7.1 builds a much richer menu:
CommonStrings::showInFileBrowser())This PR rewrites the oc list to match, and corrects the VFS toggle wording (
Activate/Deactivate virtual files, notEnable/Disable virtual file support).Source of truth
owncloud/client@7.1:src/gui/FoldersGui/accountfolderscontroller.cpp:120-247.🤖 Generated with Claude Code