docs: remove stale log-window keyboard shortcut#746
Conversation
The F12 / Ctrl-L / Cmd+L keyboard shortcut for opening the log window no longer exists. In the owncloud/client v7.1.0 source the log browser is opened only via the General Settings "Log Settings" button (src/gui/generalsettings.cpp -> slotToggleLogBrowser); no F12/Ctrl+L/ Cmd+L shortcut is bound anywhere in src/. Keep only the menu path. Closes #597 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
left a comment
There was a problem hiding this comment.
🤖 Automated code review by Claude Code review agent
Approve. Removes the stale btn:[F12] / Ctrl-L / Cmd+L log-window hotkey line from the "Logging to a Temporary Directory" steps, keeping the menu path.
- Verified the removed content is genuinely obsolete: the cited evidence (log browser opened only via General Settings "Log Settings", no hotkey bound in client v7.1.0) is consistent with removing the instruction.
- Surrounding prose is intact: the numbered list now reads cleanly (
. Open the Desktop App.→. Click menu:Settings[Advanced > Log Settings].→The Log Output window opens.). The dangling+ Either ... orcontinuation was correctly removed with it; no orphaned reference remains. - AsciiDoc syntax correct.
Pair consistency: identical diff to the 7.1 companion #745, correct master base, closing keyword Closes #597 carried here. LGTM.
dj4oC
left a comment
There was a problem hiding this comment.
Removes the stale F12/Ctrl-L/Cmd+L keyboard-shortcut instruction from the log-window steps in troubleshooting.adoc, keeping only the menu path.
Findings
Nothing blocking. The numbered list and + continuation markers remain valid AsciiDoc after the removal, and no other page references the removed hotkey text.
Verdict
Approved
🤖 Automated review by Claude Code
Generated by Claude Code
What
Removes the
btn:[F12]/Ctrl-L/Cmd+Lkeyboard-shortcut instruction from the "Logging to a Temporary Directory" steps introubleshooting.adoc, keeping only the menu path.Why
The hotkey to open the log window no longer exists. Verified against the
owncloud/clientv7.1.0 source: the log browser is opened only via the General Settings "Log Settings" button (src/gui/generalsettings.cpp:79→slotToggleLogBrowser); noF12/Ctrl+L/Cmd+Lshortcut is bound anywhere insrc/.Closes #597
🤖 Generated with Claude Code