docs: remove broken force-upload xref#734
Conversation
The xref:force-uploading-conflicted-files[] link in conflicts.adoc pointed to an anchor that does not exist anywhere in the module, so Antora emitted a "target of xref not found" warning. The "Force Uploading Conflicted Files" feature is not documented in this branch. Drop the dangling link while keeping the sentence intact. Closes #723 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
left a comment
There was a problem hiding this comment.
🤖 Automated code review by Claude Code review agent
Verdict: Approve. Verified on master.
- Searched the whole repo for
force-uploading-conflicted-files: the only match is the dangling xref line itself (conflicts.adoc:20). No section heading, no explicit[[force-uploading-conflicted-files]]anchor, and no matching attribute exists, so Antora would emit "target of xref not found". Removing the link is the right call given the feature is undocumented in this branch. - The surrounding sentence remains grammatical and complete after removal ("...have not been sent to the server.").
- Scope docs-only (+1/-1); no broken AsciiDoc.
Pair consistency: Paired with #733 (7.1); identical change, baseRefName master. Consistent.
|
"conflict file uploading" is mentioned in https://github.com/owncloud/docs-client-desktop/blob/master/modules/ROOT/pages/using.adoc Maybe the feature has some different words to describe it, and maybe it is documented somewhere? |
dj4oC
left a comment
There was a problem hiding this comment.
Removes a dangling xref:force-uploading-conflicted-files[...] link in conflicts.adoc, since no matching anchor/section exists in this branch.
Findings
Nothing blocking — this fixes a genuine broken cross-reference. The surrounding sentence remains grammatical and complete after removal.
Verdict
Approved
🤖 Automated review by Claude Code
Generated by Claude Code
What
Removes the dangling
xref:force-uploading-conflicted-files[Force Uploading Conflicted Files]link inconflicts.adoc:20.Why
No section, heading, or explicit anchor with the id
force-uploading-conflicted-filesexists anywhere in the module, so Antora emits a "target of xref not found" warning. The feature is not documented in this branch. The sentence remains intact without the dangling link.Closes #723
🤖 Generated with Claude Code