feat(config): map missing config keys to env vars#516
Open
DeepDiver1975 wants to merge 1 commit into
Open
Conversation
Add environment variables for three config keys that had no corresponding env-var mapping in the image config template: - OWNCLOUD_USER_BACKENDS -> user_backends (closes #490) - OWNCLOUD_CUSTOMGROUPS_DISALLOW_ADMIN_ACCESS_ALL and OWNCLOUD_CUSTOMGROUPS_DISALLOWED_GROUPS -> customgroups.* (closes #491) - OWNCLOUD_LOGIN_POLICY_GROUP_FORBID_MAP -> loginPolicy.groupLoginPolicy.forbidMap (closes #493) The user_backends and forbidMap keys are nested/named arrays that the flat env-var idioms cannot express, so they use the JSON-encoded pattern already established for OWNCLOUD_LOG_CONDITIONS. Mappings are added to v24.04 only, matching the convention that v20.04/v22.04 are frozen. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds environment-variable mappings for three ownCloud
config.phpkeys that were documented/available as config keys but had no corresponding env var in the image config template.OWNCLOUD_USER_BACKENDSuser_backendsOWNCLOUD_CUSTOMGROUPS_DISALLOW_ADMIN_ACCESS_ALLcustomgroups.disallow-admin-access-allOWNCLOUD_CUSTOMGROUPS_DISALLOWED_GROUPScustomgroups.disallowed-groupsOWNCLOUD_LOGIN_POLICY_GROUP_FORBID_MAPloginPolicy.groupLoginPolicy.forbidMapDetails
user_backendsandloginPolicy.groupLoginPolicy.forbidMapare nested/named arrays that the flatgetenv → string/explode()idioms cannot express, so they use the JSON-encoded pattern already established forOWNCLOUD_LOG_CONDITIONS(json_decode(...)guarded byis_array). Invalid JSON is silently ignored, leaving the key unset.customgroups.*are two simple keys: a boolean and a comma-separated list — mapped with the existing=== 'true'andexplode(',', ...)idioms. These are the only twocustomgroups.config keys (verified against theowncloud/customgroupsapp source).v24.04only, matching the established convention thatv20.04/v22.04templates are frozen and only22.04/24.04are built by CI.ENVIRONMENT.mdgains alphabetically-placed entries for each var;CHANGELOG.mdgets a dated section.Config-key shapes were validated against ownCloud org repos (
owncloud/core,owncloud/docs-server,owncloud/customgroups,user_external).Verification
php -lpasses on all three templates.php -rdumping$CONFIG: each key appears with the correct shape when its var is set, is absent when unset, and invalid JSON is safely ignored.Closes #490
Closes #491
Closes #493
🤖 Generated with Claude Code