Remove lua54 from fxmanifest (lua53 deprecation)#759
Conversation
Signed-off-by: Lukas Döring <lksdrng@icloud.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the resource manifest/runtime gating to stop explicitly opting into Lua 5.4, aligning with the stated “lua53 deprecation” direction.
Changes:
- Removed
lua54 'yes'fromfxmanifest.lua. - Removed the
_VERSIONLua 5.4 guard frominit.lua.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| init.lua | Removes the explicit Lua 5.4 runtime check from the import entrypoint. |
| fxmanifest.lua | Removes the manifest-level Lua 5.4 opt-in directive. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,6 +1,5 @@ | |||
| fx_version 'cerulean' | |||
| use_experimental_fxv2_oal 'yes' | |||
There was a problem hiding this comment.
Removing lua54 'yes' means the Lua version is no longer explicitly selected by the manifest. The codebase still contains Lua 5.4-only syntax (e.g. to-be-closed variables using <close> in imports/zones/shared.lua), which will produce a syntax error if the resource is executed under Lua 5.3. If Lua 5.4 is still a hard requirement, ensure it’s enforced somewhere (keep the manifest flag if still supported by current runtimes, or otherwise enforce via minimum server build/docs/runtime check) so users don’t hit runtime parse failures.
| use_experimental_fxv2_oal 'yes' | |
| use_experimental_fxv2_oal 'yes' | |
| lua54 'yes' |
|
|
||
| if not _VERSION:find('5.4') then | ||
| error('Lua 5.4 must be enabled in the resource manifest!', 2) | ||
| end | ||
|
|
||
| local resourceName = GetCurrentResourceName() | ||
| local ox_lib = 'ox_lib' | ||
|
|
There was a problem hiding this comment.
The Lua 5.4 runtime guard was removed. Given the project still includes Lua 5.4-only syntax in modules that can be loaded later, this change makes incompatibility show up as a less actionable syntax error during module import. Consider reinstating an explicit version check here (with an updated message that no longer references enabling lua54 in the manifest) so users get a clear failure explaining that Lua 5.4/server artifact support is required.
No description provided.