Skip to content

Avoid awkward special case for point class #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid awkward special case for point class #2467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/geom.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,17 +200,21 @@ class multigeometry_t
using iterator = typename std::vector<GEOM>::iterator;
using value_type = GEOM;

static constexpr bool FOR_POINT = std::is_same_v<GEOM, point_t>;

[[nodiscard]] std::size_t num_geometries() const noexcept
{
return m_geometry.size();
}

GEOM &
add_geometry(typename std::conditional_t<FOR_POINT, point_t, GEOM &&> geom)
GEOM &add_geometry(GEOM const &geom)
{
m_geometry.push_back(geom);
return m_geometry.back();
}

template <typename T>
GEOM &add_geometry(T &&geom)
{
m_geometry.push_back(std::forward<GEOM>(geom));
m_geometry.push_back(std::forward<T>(geom));
return m_geometry.back();
}

Expand Down
Loading