Skip to content

fix(xtest): run pqc tests after km kas startup#464

Merged
dmihalcik-virtru merged 1 commit into
mainfrom
fix/start-km-kas-before-pqc
Jun 1, 2026
Merged

fix(xtest): run pqc tests after km kas startup#464
dmihalcik-virtru merged 1 commit into
mainfrom
fix/start-km-kas-before-pqc

Conversation

@jakedoublev
Copy link
Copy Markdown
Contributor

@jakedoublev jakedoublev commented Jun 1, 2026

Addresses failing job when testing opentdf service v0.16.0: https://github.com/opentdf/platform/actions/runs/26779244647/job/78942175284?pr=3450

Summary by CodeRabbit

  • Tests
    • Reorganized test suite execution to consolidate PQC (Post-Quantum Cryptography) test coverage within attribute-based configuration test runs, streamlining test workflow organization.

Signed-off-by: jakedoublev <jake.vanvorhis@virtru.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5e0b6a92-fa48-4820-a786-32c38a985d1a

📥 Commits

Reviewing files that changed from the base of the PR and between bffff1c and 852d1e4.

📒 Files selected for processing (1)
  • .github/workflows/xtest.yml

📝 Walkthrough

Walkthrough

The workflow reorganizes xtest coverage by removing test_pqc.py from standard and SDK-specific test runs, and adding it to the ABAC-focused test suite instead. This consolidates PQC testing within attribute-based configuration validation.

Changes

Test Suite Reorganization

Layer / File(s) Summary
Move PQC tests from standard to ABAC-focused runs
.github/workflows/xtest.yml
Standard xtests (all SDK and SDK-specific variants) remove test_pqc.py from the pytest invocation, while ABAC-focused tests add test_pqc.py alongside test_abac.py. This consolidates PQC coverage under ABAC test runs instead of standard runs.

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • opentdf/tests#443: Both PRs modify .github/workflows/xtest.yml to control whether test_pqc.py is included in specific pytest invocations (previous PR added it to standard runs, this PR removes it from standard runs and shifts it into ABAC-focused runs).

Suggested reviewers

  • pflynn-virtru

Poem

🐰 Hopping through the workflow with glee,
PQC tests find their rightful spree,
From standard runs, they take their flight,
To ABAC's arms, where they belong just right,
Organization complete, tests are free! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(xtest): run pqc tests after km kas startup' clearly describes the main change: reordering PQC tests to run after KM KAS startup, which aligns with the raw summary showing PQC tests were moved to the ABAC-focused test set.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/start-km-kas-before-pqc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 1, 2026

@dmihalcik-virtru
Copy link
Copy Markdown
Member

d'oh sorry rebased the wrong branch

@jakedoublev
Copy link
Copy Markdown
Contributor Author

@dmihalcik-virtru should we do this, or do you have a different path forward?

@jakedoublev jakedoublev marked this pull request as ready for review June 1, 2026 21:21
@jakedoublev jakedoublev requested review from a team as code owners June 1, 2026 21:21
@dmihalcik-virtru dmihalcik-virtru merged commit fbc8022 into main Jun 1, 2026
24 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the fix/start-km-kas-before-pqc branch June 1, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants