build an extra image rebasebot-podman#81455
Conversation
|
@hongkailiu: GitHub didn't allow me to request PR reviews from the following users: nobody. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/pj-rehearse |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis PR adds a ChangesRebasebot podman image config
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hongkailiu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-eng/rebasebot/openshift-eng-rebasebot-main.yaml`:
- Line 41: The working directory permissions are too broad because the current
chmod in the container setup makes the directory world-writable. Update the
chmod in the build/setup step that follows the chown to default so it uses a
tighter mode such as 0755, or 0770 only if group write access is required, and
keep the fix localized to the directory permission setting in this YAML.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: cecd2055-61f0-4bfa-bc0c-4f75804afcf9
📒 Files selected for processing (1)
ci-operator/config/openshift-eng/rebasebot/openshift-eng-rebasebot-main.yaml
hongkailiu
force-pushed
the
rebasebot-podman
branch
2 times, most recently
from
e5211be to
430ecae
Compare
|
/pj-rehearse |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-eng-rebasebot-main-images |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
hongkailiu
force-pushed
the
rebasebot-podman
branch
from
430ecae to
e2e7535
Compare
|
/pj-rehearse pull-ci-openshift-eng-rebasebot-main-images |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-eng-rebasebot-main-images |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
hongkailiu
force-pushed
the
rebasebot-podman
branch
from
97e466e to
3b76839
Compare
|
/pj-rehearse pull-ci-openshift-eng-rebasebot-main-images |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
hongkailiu
force-pushed
the
rebasebot-podman
branch
from
3b76839 to
710d6d1
Compare
|
/pj-rehearse pull-ci-openshift-eng-rebasebot-main-images |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
We can install others on demand later.
hongkailiu
force-pushed
the
rebasebot-podman
branch
from
710d6d1 to
44280fe
Compare
|
/pj-rehearse pull-ci-openshift-eng-rebasebot-main-images |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@hongkailiu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
/cc nobody
Summary by CodeRabbit
This PR updates the OpenShift CI operator configuration for the rebasebot workflow (
ci-operator/config/openshift-eng/rebasebot/openshift-eng-rebasebot-main.yaml) to add an additionalrebasebot-podmanimage variant.Concretely, it introduces a reusable
base_images.nested-podmanbase (nested-podmanin thecinamespace,latest) and uses that base to buildrebasebot-podmanvia an inlinedockerfile_literal. The new image sets up a “Docker-like” interface by symlinking/usr/local/bin/dockerto Podman, copies the rebasebot source from/go/src/github.com/openshift-eng/rebasebotinto the image assrc, installsuvand the rebasebot Python package (pip install .), then prepares/workingfor execution before switching toUSER 1001:1001. The existingrebasebotimage definition remains unchanged.