Skip to content

openshift-logging: Remove unused Loki versions#81453

Open
xperimental wants to merge 1 commit into
openshift:mainfrom
xperimental:loki-remove-unused
Open

openshift-logging: Remove unused Loki versions#81453
xperimental wants to merge 1 commit into
openshift:mainfrom
xperimental:loki-remove-unused

Conversation

@xperimental

@xperimental xperimental commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

/cc @JoaoBraveCoding
/assign @xperimental

Summary by CodeRabbit

Removed obsolete OpenShift CI configuration for unused Loki upstream versions, which stops CI from generating and running jobs for those versions in the openshift-release infrastructure.

This cleanup affects the OpenShift Loki build/test/release setup by deleting the v3.5.7 and v3.7.2 ci-operator configs, including their associated image build targets, promotion/release settings, resource requests, and test steps.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e0756051-a2ae-46ae-93b7-6ac3b8216198

📥 Commits

Reviewing files that changed from the base of the PR and between 6c9eb48 and 008983b.

⛔ Files ignored due to path filters (4)
  • ci-operator/jobs/openshift/loki/openshift-loki-upstream-v3.5.7-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/loki/openshift-loki-upstream-v3.5.7-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/loki/openshift-loki-upstream-v3.7.2-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/loki/openshift-loki-upstream-v3.7.2-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/loki/openshift-loki-upstream-v3.5.7.yaml
  • ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml
💤 Files with no reviewable changes (2)
  • ci-operator/config/openshift/loki/openshift-loki-upstream-v3.5.7.yaml
  • ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml

Walkthrough

This pull request removes two ci-operator configuration files for OpenShift Loki upstream builds (v3.5.7 and v3.7.2), deleting their image build, promotion, resource, and test definitions with no replacement content provided.

Changes

Cohort / File(s) Summary
Removed Loki upstream CI configs
ci-operator/config/openshift/loki/openshift-loki-upstream-v3.5.7.yaml, ci-operator/config/openshift/loki/openshift-loki-upstream-v3.7.2.yaml
Deletes both YAML configuration files, removing image build targets, promotion settings, resource requests, and test step definitions for the respective Loki upstream versions.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing unused Loki version configs from openshift-logging.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Diff only deletes ci-operator YAMLs; no Ginkgo test files or It()/Describe()/Context()/When() titles were added or changed.
Test Structure And Quality ✅ Passed No Ginkgo test code was changed; the PR only deletes Loki CI YAML/job configs, so this test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only CI/job YAML files were deleted; no new Ginkgo e2e tests or API usages were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only deletes ci-operator config/job YAML; no Go/Ginkgo tests were added or modified, so SNO compatibility is not implicated.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The PR only deletes ci-operator YAMLs; no deployment manifests or controllers were added/modified, and the removed files contain no scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR only deletes YAML ci-operator config/job files; no Go binaries, main/init/TestMain, or stdout-writing setup was changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only deletes Loki CI config/job YAMLs; no new Ginkgo e2e tests or network-dependent code were added.
No-Weak-Crypto ✅ Passed The PR only deletes Loki CI/job YAMLs; the full diff contains no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret-comparison code.
Container-Privileges ✅ Passed The PR only deletes six Loki CI/job YAMLs; the patch has 0 added lines and no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation additions.
No-Sensitive-Data-In-Logs ✅ Passed PASS: The commit only deletes Loki CI/job YAML files; no new logging code or embedded sensitive values were added, and the removed files contained only secret references by name/path.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2026
@xperimental xperimental force-pushed the loki-remove-unused branch from 6c9eb48 to 008983b Compare July 3, 2026 15:13
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 3, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@xperimental: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@xperimental: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant