Skip to content

Add EXTENSIONS_YUM_REPO_NAMES build arg to openshift/os extensions images#81446

Open
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:art-19543-extensions-build-args
Open

Add EXTENSIONS_YUM_REPO_NAMES build arg to openshift/os extensions images#81446
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:art-19543-extensions-build-args

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

The openshift/os PR #1945 refactors the extensions build to use dnf download instead of rpm-ostree compose. This introduces a new EXTENSIONS_YUM_REPO_NAMES build arg in extensions/Containerfile that must be supplied at build time.

Without this change, the CI extensions image builds (rhel-coreos-extensions and rhel-coreos-10-extensions) fail with:

Error: Unknown repo: 'overridden'

because the placeholder default value overridden is used literally as a dnf repo name.

This PR adds the EXTENSIONS_YUM_REPO_NAMES build arg to both extensions image definitions in the ci-operator configs for openshift/os (master and release-5.0 branches), mirroring the existing YUM_REPO_NAMES pattern used by the node image builds.

Changes

  • openshift-os-master.yaml: Added EXTENSIONS_YUM_REPO_NAMES for rhel-coreos-extensions (RHEL 9) and rhel-coreos-10-extensions (RHEL 10)
  • openshift-os-release-5.0.yaml: Same additions

Jira: ART-19543

Summary by CodeRabbit

This PR updates OpenShift OS CI build configs so the extensions image builds for both master and release-5.0 pass the new EXTENSIONS_YUM_REPO_NAMES build argument. In practice, this fixes the affected openshift/os CI jobs for the RHEL 9 and RHEL 10 extensions images by ensuring dnf download uses the correct YUM repositories, including the high-availability repos that were missing before.

…ages

Add the EXTENSIONS_YUM_REPO_NAMES build arg to the rhel-coreos-extensions
and rhel-coreos-10-extensions image definitions in both master and
release-5.0 ci-operator configs. This enables the extensions Containerfile
to install packages from the correct yum repos during CI builds.

RHEL 9 extensions: rhel-9.8-baseos,rhel-9.8-appstream,rhel-9.8-server-ose-5.0,rhel-9.8-highavailability,rhel-9.8-fast-datapath
RHEL 10 extensions: rhel-10.2-baseos,rhel-10.2-appstream,rhel-10.2-server-ose-5.0,rhel-10.2-highavailability,rhel-10.2-fast-datapath

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't checkout base SHA 38f09558d906749c161cfed6c85b753206214bf2: error checking out "38f09558d906749c161cfed6c85b753206214bf2": exit status 128 fatal: unable to read tree (38f09558d906749c161cfed6c85b753206214bf2)

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9e01a640-0e51-48ae-81f1-7880482b86ea

📥 Commits

Reviewing files that changed from the base of the PR and between f0736bc and 2c18147.

📒 Files selected for processing (2)
  • ci-operator/config/openshift/os/openshift-os-master.yaml
  • ci-operator/config/openshift/os/openshift-os-release-5.0.yaml

Walkthrough

Two CI operator configuration YAML files are updated to add a new EXTENSIONS_YUM_REPO_NAMES build argument for the "extensions" image builds, extending the YUM repo lists to include *-highavailability repos for both RHEL 9.8 and RHEL 10.2 variants.

Changes

Extensions YUM repo config update

Layer / File(s) Summary
Add highavailability repo build args
ci-operator/config/openshift/os/openshift-os-master.yaml, ci-operator/config/openshift/os/openshift-os-release-5.0.yaml
Adds EXTENSIONS_YUM_REPO_NAMES build argument to extensions image build configs for RHEL 9.8 and RHEL 10.2 variants, including the respective *-highavailability YUM repos.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Related issues: None specified

Related PRs: None specified

Suggested labels: None specified

Suggested reviewers: None specified

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: adding the EXTENSIONS_YUM_REPO_NAMES build arg to openshift/os extensions images.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes ci-operator YAML build args; no Ginkgo It/Describe/Context/When test titles are present in the touched files.
Test Structure And Quality ✅ Passed PR only changes two ci-operator YAML configs; no Ginkgo tests were added or modified, so this check is not applicable.
Microshift Test Compatibility ✅ Passed Only ci-operator YAML build args changed; no new Ginkgo tests or OpenShift API usage were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator YAML build args changed; no Ginkgo/e2e test code was added or modified, so SNO compatibility isn’t implicated.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: Only ci-operator image build args changed; no deployment manifests, controllers, replicas, affinity, nodeSelector, or spread constraints were added.
Ote Binary Stdout Contract ✅ Passed Only ci-operator YAML configs changed; no process-level Go/binary code or stdout writes were introduced, so the stdout contract isn't implicated.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates ci-operator YAML build args; no Ginkgo e2e test additions or network assumptions were introduced.
No-Weak-Crypto ✅ Passed Touched YAML only adds EXTENSIONS_YUM_REPO_NAMES repo lists; no weak crypto, custom crypto, or secret comparisons found.
Container-Privileges ✅ Passed Only EXTENSIONS_YUM_REPO_NAMES build args were added; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings changed.
No-Sensitive-Data-In-Logs ✅ Passed Only ci-operator YAML build-arg entries changed; no logging statements or sensitive data were introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from c4rt0 and jlebon July 3, 2026 12:38
@joepvd

joepvd commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@joepvd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/os/master/e2e-aws 2c18147 link unknown /pj-rehearse pull-ci-openshift-os-master-e2e-aws
ci/rehearse/openshift/os/master/okd-scos-e2e-aws-ovn 2c18147 link unknown /pj-rehearse pull-ci-openshift-os-master-okd-scos-e2e-aws-ovn
ci/rehearse/openshift/os/master/images 2c18147 link unknown /pj-rehearse pull-ci-openshift-os-master-images
ci/rehearse/openshift/os/release-5.0/e2e-aws 2c18147 link unknown /pj-rehearse pull-ci-openshift-os-release-5.0-e2e-aws
ci/rehearse/openshift/os/release-5.0/images 2c18147 link unknown /pj-rehearse pull-ci-openshift-os-release-5.0-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@travier travier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2026
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redhat-chai-bot, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants